Page MenuHomePhabricator

IP Info box: Data disclaimer isn't right aligned to the box [S]
Closed, ResolvedPublic

Description

Screen Shot 2021-08-10 at 5.50.00 PM.png (1×2 px, 481 KB)

(screenshot from {T271673#7271224})

The italics text should be on the right edge of the box (See figma)

Event Timeline

ARamirez_WMF renamed this task from IP Info box: Data disclaimer isn't right aligned to the box to IP Info box: Data disclaimer isn't right aligned to the box [S].Aug 25 2021, 4:59 PM

The content of the collapsible boxes on Special:Contributions are limited to 50 em, which explains why the disclaimer isn't fully to the right in that screenshot but is instead aligned with the right-hand edge of the User field in the "Search for contributions" box below. This limit was introduced in rMW2bb8515286da: Make Special:Contributions use OOUI and is discussed from T117736#5544873 onwards.

@Prtksxna: I have a couple of questions:

  • Should we ignore this limit for just this element or the entire box?
    • My guess is the latter and that how I'll proceed initially
  • At ~1024 px width, the disclaimer is visually unrelated to the content (see the following). Should we account for that?

Screenshot 2021-09-01 at 15.03.51.png (1×2 px, 331 KB)

Thanks for sharing the details and screenshots, Sam!

  • Should we ignore this limit for just this element or the entire box?

Yep, lets do that.

  • At ~1024 px width, the disclaimer is visually unrelated to the content (see the following). Should we account for that?

The box will eventually have 3 columns (two for IP info, one for on-wiki info), so this problem should go away.

Change 720945 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/IPInfo@master] infobox: Ignore 50em width restriction

https://gerrit.wikimedia.org/r/720945

I was curious about the 50em width restriction for collapsible boxes on the Special:Contributions change, so I've reached out to the author of the patch that introduced it. I'll report back when they respond.

Change 720945 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] infobox: Ignore 50em width restriction

https://gerrit.wikimedia.org/r/720945

This looks good. Moving to Done.


@phuedx and I discussed that we'll use the full width here with flexible columns. This way when desktop refresh is deployed the UI will continue to work in the limited horizontal space (~960px)