(screenshot from {T271673#7271224})
The italics text should be on the right edge of the box (See figma)
• Prtksxna | |
Aug 12 2021, 5:13 AM |
F34651201: Screen Shot 2021-09-22 at 4.38.53 PM.png | |
Sep 22 2021, 8:58 PM |
F34627807: Screenshot 2021-09-01 at 15.03.51.png | |
Sep 1 2021, 2:29 PM |
F34590031: Screen Shot 2021-08-10 at 5.50.00 PM.png | |
Aug 12 2021, 5:13 AM |
The italics text should be on the right edge of the box (See figma)
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
infobox: Ignore 50em width restriction | mediawiki/extensions/IPInfo | master | +6 -0 |
The content of the collapsible boxes on Special:Contributions are limited to 50 em, which explains why the disclaimer isn't fully to the right in that screenshot but is instead aligned with the right-hand edge of the User field in the "Search for contributions" box below. This limit was introduced in rMW2bb8515286da: Make Special:Contributions use OOUI and is discussed from T117736#5544873 onwards.
@Prtksxna: I have a couple of questions:
Thanks for sharing the details and screenshots, Sam!
Yep, lets do that.
- At ~1024 px width, the disclaimer is visually unrelated to the content (see the following). Should we account for that?
The box will eventually have 3 columns (two for IP info, one for on-wiki info), so this problem should go away.
Change 720945 had a related patch set uploaded (by Phuedx; author: Phuedx):
[mediawiki/extensions/IPInfo@master] infobox: Ignore 50em width restriction
I was curious about the 50em width restriction for collapsible boxes on the Special:Contributions change, so I've reached out to the author of the patch that introduced it. I'll report back when they respond.
Change 720945 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] infobox: Ignore 50em width restriction
This looks good. Moving to Done.
@phuedx and I discussed that we'll use the full width here with flexible columns. This way when desktop refresh is deployed the UI will continue to work in the limited horizontal space (~960px)