[2021-08-12T18:00:46,822][WARN ][o.e.d.i.q.BoolQueryBuilder] [gXPW_Qb] Should clauses in the filter context will no longer automatically set the minimum should match to 1 in the next major version. You should group them in a [filter] clause or explicitly set [minimum_should_match] to 1 to restore this behavior in the next major version.
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T248925 Make MediaWiki release tarball compatible with PHP 8.0 | |||
| Resolved | Jdforrester-WMF | T300463 Make PHP 8.0 voting on MW master | |||
| Resolved | None | T283275 Make MW master tests pass on PHP 8.0 | |||
| Resolved | Reedy | T268861 CirrusSearch uses Elastica's Match class | |||
| Resolved | Reedy | T268863 Translate uses Elastica's Match class | |||
| Resolved | matthiasmullie | T268866 WikibaseMediaInfo uses Elastica's Match class | |||
| Invalid | None | T268864 WikibaseCirrusSearch uses Elastica's Match class | |||
| Resolved | Reedy | T268865 WikibaseLexemeCirrusSearch uses Elastica's Match class | |||
| Resolved | EBernhardson | T271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 | |||
| Resolved | Gehel | T263142 [EPIC] Upgrade Elasticsearch to version 7.10 | |||
| Resolved | EBernhardson | T218994 Deprecation warning on elasticsearch 6 | |||
| Resolved | • EJoseph | T288765 Always provide minimum_should_match in bool queries |
Event Timeline
Comment Actions
Change 775276 had a related patch set uploaded (by EJoseph; author: EJoseph):
[mediawiki/extensions/CirrusSearch@master] Explicitly set minimum_should_match to 1
Comment Actions
Change 775276 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Explicitly set minimum_should_match to 1
Comment Actions
Change 787701 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/CirrusSearch@master] Filters::booleanOr should set minimul_should_match to 1
Comment Actions
Change 787705 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Temporarily comment one test case
Comment Actions
Change 787706 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix and re-enable test related to minimum_should_match
Comment Actions
Change 787523 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/WikibaseMediaInfo@master] Update minimum_should_match for deprecations in 7
Comment Actions
Change 787705 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Temporarily comment one test case
Comment Actions
Change 787701 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Filters::booleanOr should set minimul_should_match to 1
Comment Actions
Change 787706 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix and re-enable test related to minimum_should_match
Comment Actions
Change 787523 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Update minimum_should_match for deprecations in 7
Comment Actions
Change 792278 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] haslicense: Apply minimum_should_match for elastic 7.x
Comment Actions
Unfortunately incomplete, reviewing deprecation logs since turning them on last week shows both CirrusSearch and MediaSearch are still triggering this warning. Needs investigation.
Cirrus reproduction: https://en.wikipedia.org/w/index.php?sort=random&search=foobar+insource%3Aqwerty&title=Special%3ASearch&fulltext=1&ns0=1&cirrusDumpQuery
- Query chosen from logstash, with words changed. Logging makes it look like the warning comes from the query generated by second chance search with PhraseSuggestFallbackMethod
MediaSearch reproduction: https://commons.wikimedia.org/wiki/Special:Search?fulltext=1&search=haslicense:other&ns0=1&ns6=1&ns12=1&ns14=1&ns100=1&ns106=1
- Not specifically MediaSearch, but MediaSearch uses haslicense keyword which is triggering the warning.
Comment Actions
Change 792287 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/CirrusSearch@master] Resolve additional minimum_should_match deprecation warnings
Comment Actions
Change 792278 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] haslicense: Apply minimum_should_match for elastic 7.x
Comment Actions
Change 792287 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Resolve minimum_should_match warnings during random scoring
Comment Actions
These patches didn't make the tuesday branch cut, intending to cherry-pick them out to clean up the deprecation logs and make it more clear if we have them mostly resolved now.
Comment Actions
Change 792649 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.12] Resolve minimum_should_match warnings during random scoring
Comment Actions
Change 792650 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.39.0-wmf.12] haslicense: Apply minimum_should_match for elastic 7.x
Comment Actions
Change 792650 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@wmf/1.39.0-wmf.12] haslicense: Apply minimum_should_match for elastic 7.x
Comment Actions
Change 792649 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.12] Resolve minimum_should_match warnings during random scoring
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-18T07:32:51Z] <dcausse@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/CirrusSearch/includes/Query/FullTextSimpleMatchQueryBuilder.php: Backport: [[gerrit:792649|Resolve minimum_should_match warnings during random scoring (T288765)]] (duration: 00m 56s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-18T07:34:51Z] <dcausse@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/WikibaseCirrusSearch/src/Query/HasLicenseFeature.php: Backport: [[gerrit:792650|haslicense: Apply minimum_should_match for elastic 7.x (T288765)]] (duration: 00m 52s)
Comment Actions
Change 812324 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/ImageSuggestions@master] Add script to generate notifications for a given list of users & categories
Comment Actions
Ignore above comment. I was looking at this task for other reasons and accidentally ended up copying the wrong id. I have since updated that patch's commit with the correct ticket id.