Page MenuHomePhabricator
Create Task
Maniphest T288790

TypeError: Argument 1 passed to MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php on line 3966
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php on line 3966
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.18/extensions/Math/src/HookHandlers/ParserHooksHandler.php(71)
#0 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(3966): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->mathTagHook(NULL, array, Parser, PPFrame_Hash)
#1 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/PPFrame_Hash.php(351): Parser->extensionSubstitution(array, PPFrame_Hash)
#2 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(2923): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#3 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(1591): Parser->replaceVariables(string)
#4 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(849): Parser->internalParse(string, boolean, boolean)
#5 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(898): Parser->recursiveTagParse(string)
#6 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/extension/src/Config/DataAccess.php(290): Parser->parseExtensionTagAsTopLevelDoc(string)
#7 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(165): MWParsoid\Config\DataAccess->parseWikitext(MWParsoid\Config\PageConfig, string)
#8 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(308): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onExtension(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#9 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(202): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#10 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(118): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#11 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(168): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#12 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(166): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#13 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/HTML5TreeBuilder.php(420): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#14 [internal function]: Wikimedia\Parsoid\Wt2Html\HTML5TreeBuilder->processChunkily(string, array)
#15 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(961): Generator->current()
#16 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#17 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(307): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#18 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#19 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Parsoid.php(166): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#20 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/src/Parsoid.php(198): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#21 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(588): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#22 /srv/mediawiki/php-1.37.0-wmf.18/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(88): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#23 /srv/mediawiki/php-1.37.0-wmf.18/includes/Rest/Router.php(403): MWParsoid\Rest\Handler\PageHandler->execute()
#24 /srv/mediawiki/php-1.37.0-wmf.18/includes/Rest/Router.php(330): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#25 /srv/mediawiki/php-1.37.0-wmf.18/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#26 /srv/mediawiki/php-1.37.0-wmf.18/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#27 /srv/mediawiki/php-1.37.0-wmf.18/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#28 /srv/mediawiki/w/rest.php(3): require(string)
#29 {main}
Impact
  • Saw a spike of these briefly, seems to be happening only for wikipedia
Notes

Details

Request URL
https://sq.wikipedia.org/w/rest.php/sq.wikipedia.org/v3/page/pagebundle/*/2183278

Related Objects

Event Timeline

thcipriani created this task.Aug 12 2021, 11:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2021, 11:47 PM
Zabe merged a task: T288846: TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given.Aug 13 2021, 6:30 PM
Zabe added subscribers: geraki, Zabe.
Arlolra edited projects, added Parsoid (Tracking), Math; removed Parsoid.Aug 13 2021, 7:11 PM
Arlolra added a subscriber: Arlolra.

Visiting https://sq.wikipedia.org/wiki/*?oldid=2183278 also raises an error Përjashtim fatal i tipit "TypeError"

Zabe added subscribers: • Pchelolo, Physikerwelt.Aug 13 2021, 8:00 PM

Like T288846 this was probably caused by rEMATe9bc5d3a4229: Switch parser hooks to a new-style hook handler.

cc @Pchelolo @Physikerwelt

Zabe moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 13 2021, 8:40 PM
Zabe added a comment.Aug 13 2021, 9:12 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/713002/ should fix this.

Stashbot mentioned this in T288846: TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given.Aug 16 2021, 12:15 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-16T12:15:44Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/Math/src/HookHandlers/ParserHooksHandler.php: Backport: [[gerrit:712962|Support null content in parser tag hook (T288846)]] (hopefully also fixes T288790) (duration: 00m 59s)

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 16 2021, 12:25 PM
Lucas_Werkmeister_WMDE assigned this task to • Pchelolo.
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.

As far as I can tell, this is fixed now.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL