Sass compiler warning regarding BouncingDots mixin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Aug 13 2021, 10:34 AM

Description

While transpiling code from sass to css in the Mismatch Finder project, the compiler emits the following warning:

: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(1em, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
658 │ $wikit-BouncingDots-margin-left: 1em/4; // not sure the operation is going to work
    │                                  ^^^^^
    ╵
    node_modules/@wmde/wikit-tokens/dist/_variables.scss 658:34  @import
    resources/sass/app.scss 5:9                                  root stylesheet

We believe this is caused by the division symbol included within the BouncingDots token file.

Related Objects

Mentioned Here: T287389: Ensure exported tokens contain only values, not calculations

Event Timeline

Silvan_WMDE created this task.Aug 13 2021, 10:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2021, 10:34 AM

PR: https://github.com/wmde/wikit/pull/455

ItamarWMDE claimed this task.Aug 13 2021, 11:03 AM

ItamarWMDE moved this task from Incoming to Needs review on the Wikidata Design System board.

ItamarWMDE moved this task from Backlog to Mismatch Finder - sprint 4 on the Mismatch Finder board.

ItamarWMDE edited projects, added Mismatch Finder (Mismatch Finder - sprint 4); removed Mismatch Finder.

ItamarWMDE moved this task from To Do to Peer Review on the Mismatch Finder (Mismatch Finder - sprint 4) board.

ItamarWMDE moved this task from Mismatch Finder - sprint 4 to Backlog on the Mismatch Finder board.

ItamarWMDE edited projects, added Mismatch Finder; removed Mismatch Finder (Mismatch Finder - sprint 4).

ItamarWMDE moved this task from Needs review to Done on the Wikidata Design System board.Aug 13 2021, 12:29 PM

The underlying issue of style dictionary not being able to handle operations in the token values is tracked here https://phabricator.wikimedia.org/T287389

Removing Mismatch finder tag, as this has already been done, and should be managed for bookkeeping only in the Design System board, as it was a DS issue.

ItamarWMDE moved this task from Needs review to Done on the Wikidata Design System board.

Setting task status to resolved as it seems there is no work left in this task. (Please update the task status once a task is done - thanks a lot!)

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptFeb 1 2023, 12:31 PM

Sass compiler warning regarding BouncingDots mixinClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Sass compiler warning regarding BouncingDots mixin
Closed, ResolvedPublic
Actions