Test that Wikibase/Wikidata namespaces declare their content model
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

To prevent T288724 from happening again, we should test at some level that entity namespaces have the right "defaultcontentmodel" in the action=query&meta=siteinfo&siprop=namespaces API response, since Pywikibot and probably others rely on this information.

A browser test or API integration test is probably the best option for this, though I’m not sure if we can make those tests work on any wiki, even if it doesn’t have local entities (e.g. how Commons is a Wikibase repository but has no namespaces with wikibase-item or wikibase-property default content model). If all else fails, we could write a test that specifically targets Wikidata (where we know the right namespaces), and run it nightly against (Beta) Wikidata.

https://github.com/wikimedia/Wikibase/tree/master/tests/api-testing

Acceptance criteria 🏕️🌟(18 August 2021)

API integration test for Wikibase covering the defaultcontentmodel case

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add API integration tests for namespace default content models	mediawiki/extensions/Wikibase	master	+41 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lucas_Werkmeister_WMDE	T288724 defaultcontentmodel missing from most namespaces in Wikidata namespaces siteinfo (breaks pywikibot)
		Resolved		Lucas_Werkmeister_WMDE	T288820 Test that Wikibase/Wikidata namespaces declare their content model

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 13 2021, 1:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2021, 1:55 PM

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 9:37 AM

Addshore moved this task from To Prioritize to Triaged High (100+) on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 2:41 PM

Addshore added a project: Wikidata-Campsite.Aug 18 2021, 8:02 AM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

@Lucas_Werkmeister_WMDE Do you think a test against a production site (or beta) is the right path forward here?
Or would we also test the same case if we had an API integration test within wikibase checking the output of this API for the default wikibase settings?

Well, the question is if we’re happy to have tests that work in the default / CI configuration but might break depending on local configuration, I guess?

And since we already have other API integration tests that require certain settings (data value normalization is currently off by default; Lua must be installed), I guess we are. So an API integration test is probably an acceptable option here.

Addshore updated the task description. (Show Details)Aug 18 2021, 9:38 AM

Addshore updated the task description. (Show Details)Aug 25 2021, 10:23 AM

Addshore set the point value for this task to 5.

Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Aug 25 2021, 10:25 AM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Lucas_Werkmeister_WMDE claimed this task.Aug 27 2021, 10:07 AM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 715210 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add API integration tests for namespace default content models

https://gerrit.wikimedia.org/r/715210

gerritbot added a project: Patch-For-Review.Aug 27 2021, 10:25 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2021, 10:38 AM