Filter the displayed notifications by read status.
- Add toolbar filter button with two states: unfilled (if filters not enabled) and filled (if filters are enabled)
- Create modal view with All, Read, and Unread filter options, as well as Notification Type toggle options.
- Persist filter selections to UserDefaults
- Update filter icon to be filled image when the filter options are Read or Unread (not All).
- We also need to consider the Notification Types filter toggles in this logic. Confirm with design (see question below).
- Update status bar text (actual content in forthcoming task)
Product/Design Needs:
[1] Is it intended for your Read Status Filters and Inbox Filters to be persisted between app launches?
Ideally, yes. But it's okay if it doesn't persist after a hard restart of the app.
[2] Confirmation: How is the filter icon filled/not filled state affected by these new type toggles? Is it that if one or more notification type filters are off, that can also trigger a filled icon?
The filter icon should be filled in when any of the following has occurred:
- One or more of the new types are turned to 'off'
- The read or unread only states are active
- A mix of the above two bullet points
Engineering Needs:
[1] The UI needs API on the Notifications Data Controller to interact with here
Dependencies
https://phabricator.wikimedia.org/T287298
https://phabricator.wikimedia.org/T288654
Related
https://phabricator.wikimedia.org/T288874
https://phabricator.wikimedia.org/T288773