Page MenuHomePhabricator

[Notifications] Add Trending current events push notification
Open, LowPublic

Description

Add in existing "polling" style locally constructed "push" notification for current events as an available notification types in Settings > Notifications.

  • Add toggle in Settings > Notifications view for this notification type
    • This notification should only be available as a toggle if the user has opted into push notifications
  • Use existing background polling logic and infrastructure to support constructing and pushing this notification to the user
  • Don't worry about creating a new notifications center cell type or adding this to the notifications center [1] – this will only be visible as a local iOS-style device notification

Product/Design Needs:
[1] To confirm, we're ok with these notifications not displaying in the Notifications Center, correct? Also, since the existing engineering infrastructure for these are for them to be presented like a local iOS-style "push" notification, it also wouldn't make sense for us to display them in the Settings > Notifications toggle table unless the user has opted in to push notifications.

Dependencies

https://phabricator.wikimedia.org/T288688
https://phabricator.wikimedia.org/T287310
https://phabricator.wikimedia.org/T287628

Event Timeline

Dmantena lowered the priority of this task from Medium to Low.Aug 13 2021, 10:34 PM

FYI this one might be a dupe of https://phabricator.wikimedia.org/T287307. I'm more in favor of closing T287307 since this one has more detail.

[1] To confirm, we're ok with these notifications not displaying in the Notifications Center, correct? Also, since the existing engineering infrastructure for these are for them to be presented like a local iOS-style "push" notification, it also wouldn't make sense for us to display them in the Settings > Notifications toggle table unless the user has opted in to push notifications.

Hi! Sorry to clarify @Dmantena by 'not displaying in the Notifications Center' do you mean the in app or system Notifications Center. I was under the assumption that we needed to remove this Notification type entirely, which I am okay with.

Ah sorry re reading, this is about re-instating this notification type.
My expectation would be that the notifications (when push is turned on) will show in the system but not the app notification center (eg user will receive a push and tapping on the push goes to the same location it did before (eg. not routed to the 'in app' notification center / message inbox)

Hi! Sorry to clarify @Dmantena by 'not displaying in the Notifications Center' do you mean the in app or system Notifications Center. I was under the assumption that we needed to remove this Notification type entirely, which I am okay with.

@cmadeo Apologies – our terms are so loaded 😅. Yeah I meant the in app Notification Center.

My expectation would be that the notifications (when push is turned on) will show in the system but not the app notification center (eg user will receive a push and tapping on the push goes to the same location it did before (eg. not routed to the 'in app' notification center / message inbox)

Your answer here is what I was looking for, thanks!

Sorry to flip flop, but I think I'd like this back on the 6.9 board, just as a final decision check before we release notifications. There may be some further news notification code cleanup to do at that point if we don't decide to support this notification.