SecurePoll: not-centrally-blocked does not distinguish partial and sitewide blocks
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Aug 14 2021, 2:06 PM

Description

What is the problem?

On the Voter Eligibility form, Must not be blocked on too many attached wikis counts both partial and sitewide blocks.

So, someone might be prevented from voting even though they are only partially blocked from wikis, even if the election does not ban partially blocked voters otherwise (e.g. Must not be partial blocked is unchecked).

Potential solutions:

Only count sitewide blocks
Have some option which allows the admin to set whether it counts partial blocks or not

Similar to the work in T268800.

Steps to reproduce problem

Create a remote election (i.e. select "All Wikis" in the "For wiki" dropdown)
Go to Special:SecurePoll/votereligibility/$id
Check Must not be blocked on too many attached wikis and put 1 in the number input
Partially block a user from a connected wiki
Login as that user and try to vote

Environment

Wiki(s): https://vote.wikimedia.org SecurePoll 3.0.0 (b1a04e4) 10:51, 9 August 2021.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Differentiate partial and sitewide blocks for central block threshold	mediawiki/extensions/SecurePoll	master	+160 -6

Customize query in gerrit

Related Objects

Mentioned Here: T268800: SecurePoll should differentiate partial blocks from full blocks
rESPOb1a04e47b23a: Merge "Add maintenance script findUsersWithRight.php"

Event Timeline

dom_walden created this task.Aug 14 2021, 2:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2021, 2:06 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Aug 18 2021, 4:10 AM

Niharika removed a project: Anti-Harassment-Team.Sep 21 2021, 8:49 PM

jrbs triaged this task as High priority.Sep 23 2022, 10:30 PM

jrbs moved this task from Backlog to Needs evaluation on the MediaWiki-extensions-SecurePoll board.

Evaluation:

Medium to high risk, as Extension:CentralAuth is involved. Apparently we can retrieve the proper block status though. Change in LocalAuth class of SecurePoll seems to be sufficient. See also https://gerrit.wikimedia.org/g/mediawiki/extensions/CentralAuth/+/e319f7b7c6692621c254d064d46098d8345761fe/includes/User/CentralAuthUser.php#2786

jrbs moved this task from Needs evaluation to Evaluated on the MediaWiki-extensions-SecurePoll board.Jan 10 2023, 2:59 PM

RamzyM-WMF subscribed.Sep 13 2023, 6:04 PM

Amdrel claimed this task.Jan 15 2025, 4:43 PM

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 15 2025, 4:43 PM

Change #1112119 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/SecurePoll@master] Differentiate partial and sitewide blocks for central block threshold

https://gerrit.wikimedia.org/r/1112119

gerritbot added a project: Patch-For-Review.Jan 17 2025, 12:27 AM

The patch I added doesn't count partial blocks against the central block threshold if 'Must not be partial blocked' is unchecked. I saw it was mentioned in the original description that we might want an admin toggle for this. Please let me know if this is something we want for this patch.

In T288887#10469077, @Amdrel wrote:

The patch I added doesn't count partial blocks against the central block threshold if 'Must not be partial blocked' is unchecked. I saw it was mentioned in the original description that we might want an admin toggle for this. Please let me know if this is something we want for this patch.

@jrbs do you have a preference?

In T288887#10469290, @Niharika wrote:

@jrbs do you have a preference?

It's a bit challenging to make a call without data but my anecdotal understanding of partial blocks is:

They are fairly rare (compared to regular blocks)
Users are usually only partially blocked from a small number of pages at a time

I cannot think of a situation in which, assuming my above assumptions are true, users might want to prevent those people from voting in elections. So I don't think the admin toggle is necessary. Scrutineers can of course also strike the vote after it is made already if for whatever reason a partial block should prevent voting.

Change #1112119 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Differentiate partial and sitewide blocks for central block threshold

https://gerrit.wikimedia.org/r/1112119

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.14; 2025-01-28).Jan 22 2025, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2025, 12:30 PM

kostajh moved this task from Evaluated to Actively working on the MediaWiki-extensions-SecurePoll board.Jan 28 2025, 8:05 PM

I assume the merged patch resolved this one. Marking as resolved. If not, feel free to re-open.

I cannot think of a situation in which, assuming my above assumptions are true, users might want to prevent those people from voting in elections. So I don't think the admin toggle is necessary.

I agree. Might make sense to create a follow-up ticket to remove [ ] Must not be partially blocked from voter eligibility completely.

OKryva-WMF added a project: Essential-Work.Oct 3 2025, 3:54 PM

SecurePoll: not-centrally-blocked does not distinguish partial and sitewide blocksClosed, ResolvedPublicBUG REPORTActions