Page MenuHomePhabricator

migrateStewards.php throws fatals
Closed, ResolvedPublicBUG REPORT

Description

When I try to run migrateStewards.php, this error message occurs.

PHP Warning:  require_once(/var/www/html/core/extensions/CentralAuth/maintenance/../../../maintenance/commandLine.inc): failed to open stream: No such file or directory in /var/www/html/core/extensions/CentralAuth/maintenance/migrateStewards.php on line 7
PHP Fatal error:  require_once(): Failed opening required '/var/www/html/core/extensions/CentralAuth/maintenance/../../../maintenance/commandLine.inc' (include_path='.:/usr/share/php') in /var/www/html/core/extensions/CentralAuth/maintenance/migrateStewards.php on line 7

This is due to commandLine.inc having been renamed to CommandLineInc.php.

Event Timeline

Change 713072 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] maintenance: fix require_once in migrateStewards.php

https://gerrit.wikimedia.org/r/713072

Patch merged, but I wouldn't be surprised if the script just continued to not work even with it -- the extension was designed for Wikimedia's purposes, and no one probably run it in a very long time.

Change 713072 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] maintenance: fix require_once in migrateStewards.php

https://gerrit.wikimedia.org/r/713072

Patch merged, but I wouldn't be surprised if the script just continued to not work even with it -- the extension was designed for Wikimedia's purposes, and no one probably run it in a very long time.

CA isn't supported outside Wikimedia wikis and this script isn't really useful to us anymore. I kind of have hopes of some other migration scripts being useful if we ever make Wikitech a SUL wiki, but this is not one of them and could possibly just be removed.

Patch merged, but I wouldn't be surprised if the script just continued to not work even with it -- the extension was designed for Wikimedia's purposes, and no one probably run it in a very long time.

Yes, the issue must have been there for many months and no one noticed, so the script is pretty much unused.

In T288903#7283499, @Majavah wrote:

Patch merged, but I wouldn't be surprised if the script just continued to not work even with it -- the extension was designed for Wikimedia's purposes, and no one probably run it in a very long time.

CA isn't supported outside Wikimedia wikis and this script isn't really useful to us anymore. I kind of have hopes of some other migration scripts being useful if we ever make Wikitech a SUL wiki, but this is not one of them and could possibly just be removed.

I'm fine with removing it.

Zabe claimed this task.
Zabe triaged this task as Low priority.
In T288903#7283499, @Majavah wrote:

Patch merged, but I wouldn't be surprised if the script just continued to not work even with it -- the extension was designed for Wikimedia's purposes, and no one probably run it in a very long time.

CA isn't supported outside Wikimedia wikis and this script isn't really useful to us anymore. I kind of have hopes of some other migration scripts being useful if we ever make Wikitech a SUL wiki, but this is not one of them and could possibly just be removed.

I'd agree with removing it.

TBH, I doubt Wikitech will become a SUL wiki in the foreseeable future (it has many consequences/blockers -- to name some, move any kind of LDAP relevance out of wikitech). It will hopefully become hosted together with all the other wikis soon though :-).

TBH, I doubt Wikitech will become a SUL wiki in the foreseeable future (it has many consequences/blockers -- to name some, move any kind of LDAP relevance out of wikitech). It will hopefully become hosted together with all the other wikis soon though :-).

True, but one can still hope, right? :P

How would you feel about removing most of the SUL migration code from CA and rewriting it if Wikitech SUL migration ever becomes realistic in the short term? I'd be surprised if any large parts of it functioned properly these days without a major rewrite and doing so would eliminate the maintenance burden of that code until/unless it would be needed.

In T288903#7283505, @Majavah wrote:

[...]
How would you feel about removing most of the SUL migration code from CA and rewriting it if Wikitech SUL migration ever becomes realistic in the short term? I'd be surprised if any large parts of it functioned properly these days without a major rewrite and doing so would eliminate the maintenance burden of that code until/unless it would be needed.

I'd feel that should be done, but...I also think that should have a separate task, so others can chime in if they want to.

I'd feel that should be done, but...I also think that should have a separate task, so others can chime in if they want to.

T288906: Remove CentralAuth SUL migration code