Page MenuHomePhabricator

Edit summary previews are no longer italic
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Open a page for editing, e.g. User talk:Tacsipacsi/sandbox.
  2. Enter some edit summary.
  3. Click Show preview or Show changes.
  4. Look at the preview of the edit summary.

Actual result

  1. The edit summary is not italic.
    Screenshot_2021-08-15 Creating User talk Tacsipacsi sandbox - Wikipedia.png (96×441 px, 7 KB)

Expected result

  1. The edit summary is shown in italic.
    Screenshot_2021-08-15 Creating User talk Tacsipacsi sandbox - Wikipedia(1).png (95×439 px, 7 KB)

Additional information

  • New regression in 1.37.0-wmf.18.
  • Tested with Monobook, legacy and new Vector, other skins may be broken as well.
  • When fixing this, care should be taken to fix both the traditional, full page reload experience, and the AJAX-based live preview (T41272).

Event Timeline

Mainframe98 added a subscriber: Mainframe98.

This regression is caused by rMWddbf011257fbe307d5ea3a583ccf5128fee3c2b0 (T278576), where the CSS style rule for span.comment was moved to interface.helpers.styles. These styles should also be loaded upon edit previewing. We failed to identify that usage, because the documentation for that style rule says Comment portions of RC entries.

Change 713074 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] EditPage: load mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/713074

I'm going to plug T125657: Gray used in .autocomment in RC and watchlist is not accessible against background and hinders link discovery here since the italics were also discussed in that task. (Feel free to fix the regression, just note that italics are bad for non-Latin script.)

Tacsipacsi renamed this task from Edit summary previews no longer italic to Edit summary previews are no longer italic.Aug 15 2021, 3:26 PM

Change 713074 merged by jenkins-bot:

[mediawiki/core@master] EditPage: load mediawiki.interface.helpers.styles

https://gerrit.wikimedia.org/r/713074

matmarex added a subscriber: matmarex.

The fix will be deployed to Wikimedia wikis this week, with the MediaWiki version 1.37.0-wmf.19, per the usual schedule (https://www.mediawiki.org/wiki/MediaWiki_1.37/Roadmap).