Page MenuHomePhabricator

Add nonwmf-extensions repository
Closed, ResolvedPublic

Description

Now that Tool-extjsonuploader supports an array of repository directories, we can add https://github.com/MWStake/nonwmf-extensions

Event Timeline

I was just experimenting with doing this, and there are two issues so far:

  • this bug: https://github.com/hamstar/Wikimate/issues/118
  • the clone.sh script still looks for the old extensionDir config key — I propose either turning this into clone.php, or changing config.php to config.json and using jq to pull out the array.

I'm not sure what this is taking about. Which uploader tool?

Samwilson updated the task description. (Show Details)

@MarkAHershberger sorry, I should've been clearer! I was relying on the Tool-extjsonuploader tag on this task; I've updated the description.

Change 713382 had a related patch set uploaded (by Samwilson; author: Samwilson):

[labs/tools/extjsonuploader@master] Move to console commands, and support updating multiple repo directories

https://gerrit.wikimedia.org/r/713382

Change 713382 merged by jenkins-bot:

[labs/tools/extjsonuploader@master] Move to console commands, and support updating multiple repo directories

https://gerrit.wikimedia.org/r/713382

I've updated the tool with the above (adding a new CLI), and deployed it. Seems to be working.

I'm not going to add the nonwmf repo yet, because in my local testing it's running up against module page size limits, and I suspect there's some extension.json stuff that we can exclude (e.g. MessagesDirs, ResourceFileModulePaths, BetaFeatures, Hooks (reduce to just the hook names), etc.). I'll make a new patch for those things.

I think it's all working now, and the module is up to date with the latest data.

Sorry about the test edits that have been happening. https://www.mediawiki.org/w/index.php?title=Module:ExtensionJson&action=history

The only issue I've seen is that DocBookExport is in both repos. I'll submit a PR to nonwmf-extensions to fix this, but I've ordered the repos in config.php so that the Gerrit ones take precedence.