Page MenuHomePhabricator

in /include/db/LoadBalancer.php function "closeConnecton" should be called "closeConnection"
Closed, ResolvedPublic

Description

Author: pieter.iserbyt

Description:
In /include/db/LoadBalancer.php it seems to me the closeConnecton function is wrongly named (typo).

Propose marking it deprecated or so and adding a new function called "closeConnection" with the old "closeConnecton" linking to the new one.


Version: 1.16.x
Severity: minor

Details

Reference
bz26895

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:21 PM
bzimport set Reference to bz26895.
bzimport added a subscriber: Unknown Object (MLST).

Seemingly there is nothing calling it in phase3 or extensions

Fixed in r80841, leaving the back compat method behind. Though, I'm not quite sure it's needed

It was added in r32578, and not changed since seemingly...

pieter.iserbyt wrote:

Thx Reedy, that was fast!

I'm using the function in an extension I'm writing: http://www.mediawiki.org/wiki/Extension:KeyValue

There might be others using it, or maybe I should not be using it...

Thx in any case! (not sure, should I close the bug now?)

RESOLVED it now. Whether to bother keeping the back compat method is something that'll get resolved in the code review