Page MenuHomePhabricator

Add image usertesting prototype: Concept A - update caption
Closed, ResolvedPublic

Description

Task

  • Make the caption a full screen modal/dialog
  • Change disabled next icon in the full-screen caption image to enabled primary icon when a caption is entered
  • Add a caption tooltip pop-up ( on the "i" icon) on the full screen modal/dialog [low priority] — will be done via T289004: Add image usertesting prototype: Concept A - update onboarding when guidance is set up

Applies to
Concept A only - this task can only be started after T288997 is completed.

Where?
Edit.html

Event Timeline

RHo renamed this task from Add image usertesting prototype: Concept A - restyle and update caption to Add image usertesting prototype: Concept A - update caption.Aug 16 2021, 8:34 PM
RHo created this task.
RHo updated the task description. (Show Details)
RHo triaged this task as Medium priority.Aug 16 2021, 8:36 PM

Hi @RHo — if the submit button on the caption page were disabled before the user enters the caption, how can the user get into the state on the right (A3ii)?

Screen Shot 2021-08-19 at 8.54.23 AM.png (878×1 px, 230 KB)

Hi @RHo — if the submit button on the caption page were disabled before the user enters the caption, how can the user get into the state on the right (A3ii)?

Screen Shot 2021-08-19 at 8.54.23 AM.png (878×1 px, 230 KB)

If the user clicks the close "x" icon in the "Add a caption" overlay, then they return to the edit page with that mandatory/error message and have to open the caption page by clicking "Add caption".

HOWEVER, for the purposes of simplicity of the prototype, I was thinking that we could not have that warning state, and if the user selects "x" on add a caption, they just return to the edit screen with Yes unselected again. Does that make sense?

I see, thanks for confirming! For this prototype, let's go w/that then.

I have a few questions about the preview page for accepted suggestions:

  • Should we show the article title and the caption? In the Figma mocks, the rejected suggestion has the article title but the accepted one doesn't.
  • What does the "Review your changes" button do? Do we need this in the prototype?

Screen Shot 2021-08-19 at 9.57.08 AM.png (854×506 px, 50 KB)
Screen Shot 2021-08-19 at 9.57.13 AM.png (860×504 px, 41 KB)

I see, thanks for confirming! For this prototype, let's go w/that then.

Ok great.

I have a few questions about the preview page for accepted suggestions:

  • Should we show the article title and the caption? In the Figma mocks, the rejected suggestion has the article title but the accepted one doesn't.
  • What does the "Review your changes" button do? Do we need this in the prototype?

Screen Shot 2021-08-19 at 9.57.08 AM.png (854×506 px, 50 KB)
Screen Shot 2021-08-19 at 9.57.13 AM.png (860×504 px, 41 KB)

Oh it should have the title in both, and the caption if yes. Sorry that was a mock-o on figma on my part but I've updated the prototype for preview to the expected for the test (I think).

Ah the "review your changes" is only on the accepted preview and should take them in real life to preview the changes like the same action in the VE edit summary. However we don't need it to be functional in the prototype for the test.
i just realised I forgot to add it to the preview page for which is annoying but will see if there's time.

Thanks @mewoph ! I've merged, but noticed that now when you click back from preview when rejecting the image, you also get the caption step. Can this be fixed in a follow-up?

Whoops I forgot the preview is also shown for rejected suggestions for ConceptA. Here's the fix: https://github.com/reetssydney/prototypes/pull/20

This and the item from T289004 are all sorted, thanks!