Page MenuHomePhabricator
Create Task
Maniphest T289040

Migrate DataModel, DataModelServices, DataModelSerialization, WBInternalSerialization to Wikibase.git
Closed, ResolvedPublic
Actions

Description

  • Migrate DataModel, DataModelServices, DataModelSerialization, WBInternalSerialization to Wikibase.git packages
  • Add patches to other Wikibase extensions to make them depend on Wikibase
  • Add a patch to Wikibase that depends on the vendor patch
  • Create a patch removing these packages from mediawiki/vendor
  • Remove the packages from composer.json
  • Add CI to create standalone git repos for these libraries and then alter the packagist configuration to read from these
  • Mark the current GitHub repos as deprecated (and maybe archive them).
  • Ensure credentials are in place and each push action runs
  • Move (De)Serializer factory to the correct place and remove hacks to load them
  • Check PHPUnit Tests
    • Lib Hooks
    • phpunit.xml
  • phan config

Note: More info in Wikibase/lib/packages/README.md

Details

SubjectRepoBranchLines +/-
FP: remove redundant phpcs in packagesmediawiki/extensions/Wikibasemaster+4 -171
Add missing packages to unit tests listmediawiki/extensions/Wikibasemaster+20 -0
FP: Remove (De)SerializerFactory class aliasesmediawiki/extensions/Wikibasemaster+0 -22
FP: Enable phpunit tests for packagesmediawiki/extensions/Wikibasemaster+13 -0
FP: tighten (De)SerializerFactory typings againmediawiki/extensions/WikibaseLexememaster+20 -13
FP: tighten (De)SerializerFactory typings againmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -3
FP: tighten (De)SerializerFactory typings againmediawiki/extensions/WikibaseMediaInfomaster+17 -15
FP: relax (De)SerializerFactory Typingsmediawiki/extensions/WikibaseMediaInfomaster+12 -14
Move (De)serializerFactory into (De)serializer Namespacemediawiki/extensions/Wikibasemaster+98 -114
FP: relax (De)SerializerFactory Typingsmediawiki/extensions/WikibaseLexememaster+9 -16
FP: relax (De)SerializerFactory Typingsmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -3
FP: Renable phpcs on packagesmediawiki/extensions/Wikibasemaster+415 -408
CI to extract new packages to standalone librariesmediawiki/extensions/Wikibasemaster+57 -0
DNM: test commit of squashed merge of datamodelmediawiki/extensions/Wikibasemaster+95 K -0
CI to extract DataModel commits to standalone librarymediawiki/extensions/Wikibasemaster+52 -33
Renable Phan for Wikibasemediawiki/extensions/Wikibasemaster+7 -11
Remove composer dependency on Wikibase DataModel librariesmediawiki/extensions/WikibaseMediaInfomaster+1 -4
Remove composer dependency on Wikibase DataModel librariesmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -3
Remove composer dependency on Wikibase DataModel librariesmediawiki/extensions/WikibaseLexememaster+0 -3
Remove composer dependency on Wikibase DataModel librariesmediawiki/extensions/PropertySuggestermaster+0 -4
Include hack to load badly namespaced classesmediawiki/extensions/Wikibasemaster+4 -0
Remove Wikibase DataModel Librariesmediawiki/vendormaster+5 -20 K
Load DataModel Libraries from extension.json not composer.jsonmediawiki/extensions/Wikibasemaster+28 -4
Merge standalone DataModel and related libraries into Wikibasemediawiki/extensions/Wikibasemaster+0 -0
Preemptively disable linting for data-model related packagesmediawiki/extensions/Wikibasemaster+3 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Tarrow created this task.Aug 17 2021, 8:36 AM
Tarrow moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.
gerritbot added a comment.Aug 17 2021, 10:44 AM

Change 713448 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] DNM: test commit of squashed merge of datamodel

https://gerrit.wikimedia.org/r/713448

gerritbot added a project: Patch-For-Review.Aug 17 2021, 10:44 AM
gerritbot added a comment.Aug 17 2021, 10:48 AM

Change 713449 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Preemptively disable linting for data-model related packages

https://gerrit.wikimedia.org/r/713449

gerritbot added a comment.Aug 17 2021, 12:51 PM

Change 713449 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Preemptively disable linting for data-model related packages

https://gerrit.wikimedia.org/r/713449

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 17 2021, 1:00 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Aug 18 2021, 8:36 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 5); removed Wikibase - Federated Properties (Federation v2 - Sprint 4).Aug 18 2021, 9:04 AM
• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.
gerritbot added a comment.Aug 19 2021, 9:05 AM

Change 713819 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Merge standalone DataModel and related libraries into Wikibase

https://gerrit.wikimedia.org/r/713819

gerritbot added a comment.Aug 19 2021, 9:19 AM

Change 713820 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Move (De)serializerFactory into (De)serializer Namespace

https://gerrit.wikimedia.org/r/713820

gerritbot added a comment.Aug 20 2021, 9:27 AM

Change 714017 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/vendor@master] Remove Wikibase DataModel Libraries

https://gerrit.wikimedia.org/r/714017

gerritbot added a comment.Aug 23 2021, 2:44 PM

Change 714370 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Load DataModel Libraries from extension.json not composer.json

https://gerrit.wikimedia.org/r/714370

Addshore mentioned this in T251872: Lower the memory footprint of ItemId, EntityId, PropertyId.Aug 24 2021, 9:34 AM
gerritbot added a comment.Aug 26 2021, 1:21 PM

Change 715016 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Renable Phan for Wikibase

https://gerrit.wikimedia.org/r/715016

gerritbot added a comment.Aug 26 2021, 1:35 PM

Change 715017 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/PropertySuggester@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715017

gerritbot added a comment.Aug 26 2021, 1:36 PM

Change 715019 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715019

gerritbot added a comment.Aug 26 2021, 1:38 PM

Change 715020 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseMediaInfo@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715020

Addshore mentioned this in T258822: Wikibase extensions do not declare extension.json dependency on Wikibase.Aug 26 2021, 1:38 PM
gerritbot added a comment.Aug 26 2021, 1:40 PM

Change 715022 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715022

gerritbot added a comment.Aug 31 2021, 1:55 PM

Change 713819 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Merge standalone DataModel and related libraries into Wikibase

https://gerrit.wikimedia.org/r/713819

gerritbot added a comment.Aug 31 2021, 1:55 PM

Change 714370 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Load DataModel Libraries from extension.json not composer.json

https://gerrit.wikimedia.org/r/714370

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.23; 2021-09-13); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 31 2021, 2:00 PM
gerritbot added a comment.Aug 31 2021, 2:55 PM

Change 715743 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Include hack to load badly namespaced classes

https://gerrit.wikimedia.org/r/715743

gerritbot added a comment.Aug 31 2021, 3:37 PM

Change 715743 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Include hack to load badly namespaced classes

https://gerrit.wikimedia.org/r/715743

gerritbot added a comment.Aug 31 2021, 3:38 PM

Change 714017 merged by jenkins-bot:

[mediawiki/vendor@master] Remove Wikibase DataModel Libraries

https://gerrit.wikimedia.org/r/714017

Jdforrester-WMF awarded a token.Aug 31 2021, 4:14 PM
gerritbot added a comment.Aug 31 2021, 4:39 PM

Change 715019 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715019

gerritbot added a comment.Aug 31 2021, 4:39 PM

Change 715017 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715017

gerritbot added a comment.Aug 31 2021, 4:40 PM

Change 715020 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715020

gerritbot added a comment.Aug 31 2021, 4:40 PM

Change 715022 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove composer dependency on Wikibase DataModel libraries

https://gerrit.wikimedia.org/r/715022

Tarrow mentioned this in rEPS61a62b8c9b71: Remove composer dependency on Wikibase DataModel libraries.Aug 31 2021, 5:18 PM
gerritbot added a comment.Aug 31 2021, 11:24 PM

Change 715016 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Renable Phan for Wikibase

https://gerrit.wikimedia.org/r/715016

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 6); removed Wikibase - Federated Properties (Federation v2 - Sprint 5).Sep 1 2021, 9:25 AM
• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.
Tarrow added a comment.Sep 7 2021, 10:42 AM

I've put up an "example" naturally slightly tweaked to show how the action will work with two consecutive new commits.
The action is available at https://github.com/tarrow/git-monorepo-splice-docker-action
An example commit on a copy of Wikibase is available at https://github.com/tarrow/Wikibase-clone/commit/0b120579b0498df7bcfb0538f6f8fd75109ccf71
The resulting job run is available at https://github.com/tarrow/Wikibase-clone/runs/3532731648
And the two commits fake added to the upstream DataModel library can be seen at: https://github.com/tarrow/WikibaseDataModel/commit/7fc86a9f0b1650825daae6c4155559bc29986d95

Tarrow added a comment.Sep 7 2021, 10:44 AM

PR for the action https://github.com/wmde/git-monorepo-splice-docker-action/pull/1 is available at the "boldly created" new Repository

gerritbot added a comment.Sep 7 2021, 10:45 AM

Change 719245 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] CI to extract DataModel commits to standalone library

https://gerrit.wikimedia.org/r/719245

Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 7 2021, 10:59 AM

Moved to peer review since I think it would be good to get the first lib (DataModel) approved before we start repeating the pattern

Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 8 2021, 11:02 AM
gerritbot added a comment.Sep 8 2021, 11:18 AM

Change 719245 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] CI to extract DataModel commits to standalone library

https://gerrit.wikimedia.org/r/719245

gerritbot added a comment.Sep 13 2021, 8:58 AM

Change 713448 abandoned by Tarrow:

[mediawiki/extensions/Wikibase@master] DNM: test commit of squashed merge of datamodel

Reason:

https://gerrit.wikimedia.org/r/713448

gerritbot added a comment.Sep 13 2021, 9:19 AM

Change 720680 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] CI to extract new packages to standalone libraries

https://gerrit.wikimedia.org/r/720680

Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 13 2021, 10:57 AM
Addshore subscribed.Sep 13 2021, 11:05 AM
gerritbot added a comment.Sep 14 2021, 9:00 AM

Change 720680 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] CI to extract new packages to standalone libraries

https://gerrit.wikimedia.org/r/720680

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 9:00 AM
Tarrow updated the task description. (Show Details)Sep 14 2021, 2:08 PM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 15 2021, 11:03 AM
gerritbot added a comment.Sep 20 2021, 10:27 AM

Change 722281 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722281

gerritbot added a comment.Sep 20 2021, 10:35 AM

Change 722284 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722284

gerritbot added a comment.Sep 20 2021, 10:57 AM

Change 722329 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseMediaInfo@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722329

gerritbot added a comment.Sep 20 2021, 11:00 AM

Change 722330 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseMediaInfo@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722330

gerritbot added a comment.Sep 21 2021, 10:01 AM

Change 722571 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722571

gerritbot added a comment.Sep 21 2021, 12:04 PM

Change 722595 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] FP: Renable phpcs on packages

https://gerrit.wikimedia.org/r/722595

gerritbot added a comment.Sep 21 2021, 4:35 PM

Change 722595 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Renable phpcs on packages

https://gerrit.wikimedia.org/r/722595

gerritbot added a comment.Sep 22 2021, 6:33 AM

Change 722813 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722813

gerritbot added a comment.Sep 22 2021, 6:41 AM

Change 722815 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] FP: Remove (De)SerializerFactory class aliases

https://gerrit.wikimedia.org/r/722815

Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 22 2021, 6:44 AM
Tarrow updated the task description. (Show Details)Sep 22 2021, 9:52 AM
gerritbot added a comment.Sep 22 2021, 12:15 PM

Change 722281 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722281

gerritbot added a comment.Sep 22 2021, 12:18 PM

Change 722571 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722571

gerritbot added a comment.Sep 22 2021, 12:21 PM

Change 722329 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] FP: relax (De)SerializerFactory Typings

https://gerrit.wikimedia.org/r/722329

gerritbot added a comment.Sep 22 2021, 12:21 PM

Change 713820 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move (De)serializerFactory into (De)serializer Namespace

https://gerrit.wikimedia.org/r/713820

gerritbot added a comment.Sep 22 2021, 12:21 PM

Change 722813 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722813

gerritbot added a comment.Sep 22 2021, 12:28 PM

Change 722330 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722330

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 22 2021, 1:00 PM
gerritbot added a comment.Sep 22 2021, 3:42 PM

Change 722284 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] FP: tighten (De)SerializerFactory typings again

https://gerrit.wikimedia.org/r/722284

gerritbot added a comment.Sep 23 2021, 10:41 AM

Change 723140 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] FP: Enable phpunit tests for packages

https://gerrit.wikimedia.org/r/723140

gerritbot added a comment.Sep 23 2021, 2:59 PM

Change 722815 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Remove (De)SerializerFactory class aliases

https://gerrit.wikimedia.org/r/722815

Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 24 2021, 11:08 AM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Sep 27 2021, 7:47 AM
gerritbot added a comment.Sep 28 2021, 10:35 AM

Change 724390 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: remove redundant phpcs in packages

https://gerrit.wikimedia.org/r/724390

gerritbot added a comment.Sep 30 2021, 7:59 AM

Change 724708 had a related patch set uploaded (by Jakob; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add missing packages to unit tests list

https://gerrit.wikimedia.org/r/724708

gerritbot added a comment.Sep 30 2021, 8:22 AM

Change 724708 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add missing packages to unit tests list

https://gerrit.wikimedia.org/r/724708

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 30 2021, 9:00 AM
gerritbot added a comment.Oct 7 2021, 8:50 AM

Change 724390 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: remove redundant phpcs in packages

https://gerrit.wikimedia.org/r/724390

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 7 2021, 9:00 AM
Jakob_WMDE closed this task as Resolved.Jan 17 2022, 8:57 AM
Jakob_WMDE moved this task from Doing to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.
Lucas_Werkmeister_WMDE mentioned this in T251382: Use strict types everywhere in Wikibase.git.Apr 22 2022, 8:32 AM
Michael mentioned this in T314987: Wikibase GitHub workflow that extracts library commits is broken.Aug 11 2022, 9:20 AM
ArthurTaylor mentioned this in T353623: [LIB] [TECH] Re-enable Phan CI checks for Wikibase libraries.Dec 18 2023, 11:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL