Page MenuHomePhabricator
Create Task
Maniphest T289046

Use core QueryBuilder for DB queries in Wikibase
Closed, ResolvedPublic
Actions

Description

Context: T243051: A query builder for MediaWiki core

Using this would improve our resilience towards mistakes and would make Wikibase code more understandable

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilderUmherirrendermediawiki/extensions/WikibaseQualityConstraintsmaster+76 -57
Migrate to IDatabase::newUpdateQueryBuilderUmherirrendermediawiki/extensions/WikibaseMediaInfomaster+8 -8
Migrate to IDatabase::newInsertQueryBuilderUmherirrendermediawiki/extensions/EntitySchemamaster+13 -6
Migrate to IDatabase::newDeleteQueryBuilderUmherirrendermediawiki/extensions/Wikibasemaster+169 -60
Migrate to IDatabase::newInsertQueryBuilder for upsertUmherirrendermediawiki/extensions/Wikibasemaster+17 -15
tests: Migrate to IDatabase::newInsertQueryBuilderUmherirrendermediawiki/extensions/Wikibasemaster+857 -468
Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilderUmherirrendermediawiki/extensions/PropertySuggestermaster+21 -4
Migrate to IDatabase::newReplaceQueryBuilderUmherirrendermediawiki/extensions/Wikibasemaster+13 -13
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Aug 17 2021, 9:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2021, 9:28 AM
Lucas_Werkmeister_WMDE subscribed.Aug 17 2021, 10:12 AM
Addshore added a project: [DEPRECATED] wdwb-tech.Aug 17 2021, 10:13 AM
Lucas_Werkmeister_WMDE added a comment.Aug 17 2021, 10:13 AM

Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/711384

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 1:19 PM
Addshore moved this task from To Prioritize to Triaged Medium (50+) on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 2:41 PM
Krinkle renamed this task from Use core's Query Builder for DB queries to Use core QueryBuilder for DB queries in Wikibase.Mar 4 2022, 9:21 AM
gerritbot added a comment.Apr 2 2024, 12:23 PM

Change #1016332 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newReplaceQueryBuilder

https://gerrit.wikimedia.org/r/1016332

gerritbot added a project: Patch-For-Review.Apr 2 2024, 12:23 PM
gerritbot added a comment.Apr 2 2024, 2:39 PM

Change #1016361 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newInsertQueryBuilder for upsert

https://gerrit.wikimedia.org/r/1016361

gerritbot added a comment.Apr 2 2024, 3:39 PM

Change #1016332 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newReplaceQueryBuilder

https://gerrit.wikimedia.org/r/1016332

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 3 2024, 2:02 PM
gerritbot added a comment.Apr 11 2024, 8:31 PM

Change #1019121 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019121

gerritbot added a comment.Apr 11 2024, 8:33 PM

Change #1019123 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseMediaInfo@master] Migrate to IDatabase::newUpdateQueryBuilder

https://gerrit.wikimedia.org/r/1019123

gerritbot added a comment.Apr 11 2024, 8:48 PM

Change #1019126 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EntitySchema@master] Migrate to IDatabase::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/1019126

gerritbot added a comment.Apr 11 2024, 8:57 PM

Change #1019127 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PropertySuggester@master] Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019127

gerritbot added a comment.Apr 12 2024, 11:29 AM

Change #1019127 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019127

Umherirrender mentioned this in rEPS45b0ff98ba4c: Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilder.Apr 12 2024, 11:34 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 12 2024, 12:00 PM
gerritbot added a comment.Apr 12 2024, 8:42 PM

Change #1019353 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019353

gerritbot added a comment.Apr 14 2024, 12:21 AM

Change #1019414 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] tests: Migrate to IDatabase::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/1019414

gerritbot added a comment.Apr 14 2024, 5:50 PM

Change #1019414 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Migrate to IDatabase::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/1019414

gerritbot added a comment.Apr 14 2024, 6:26 PM

Change #1016361 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newInsertQueryBuilder for upsert

https://gerrit.wikimedia.org/r/1016361

gerritbot added a comment.Apr 14 2024, 6:54 PM

Change #1019353 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate to IDatabase::newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019353

gerritbot added a comment.Apr 14 2024, 7:21 PM

Change #1019126 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Migrate to IDatabase::newInsertQueryBuilder

https://gerrit.wikimedia.org/r/1019126

gerritbot added a comment.Apr 14 2024, 7:46 PM

Change #1019123 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Migrate to IDatabase::newUpdateQueryBuilder

https://gerrit.wikimedia.org/r/1019123

gerritbot added a comment.Apr 14 2024, 7:46 PM

Change #1019121 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate to IDatabase::newInsertQueryBuilder/newDeleteQueryBuilder

https://gerrit.wikimedia.org/r/1019121

Umherirrender closed this task as Resolved.Apr 15 2024, 6:47 PM
Umherirrender subscribed.

Select queries are handled in other tasks, for example
T312510: Migrate usage of Database::select to SelectQueryBuilder in Wikibase
T312455: Migrate usage of Database::select to SelectQueryBuilder in PropertySuggester
T312363: Migrate usage of Database::select to SelectQueryBuilder in WikibaseQualityConstraints

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits