Maniphest T289049

Disconnect old sidebar from VE template dialog
Closed, ResolvedPublic
Actions

Description

Depending on new sidebar feature flag configuration, conditionally disable event handling for the old sidebar. If possible, also avoid creating the elements in the first place. Don't break the old sidebar when configured.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Force "new template dialog sidebar" feature flag to be true	mediawiki/extensions/VisualEditor	master	+2 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T289653 Screenreader support for the new VisualEditor template editor sidebar
		Resolved		thiemowmde	T290262 Add keyboard shortcuts for VE template dialog
		Open		None	T294521 Finishing touches on keyboard shortcuts in the new template dialog
		Resolved		thiemowmde	T299490 Add shortcuts to hover tooltips on buttons in adv toolbar
		Resolved		thiemowmde	T289043 [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane
		Resolved		thiemowmde	T290975 Synchronize scroll and focus when template dialog is in narrow-screen mode
		Resolved		Lena_WMDE	T299036 VE Dialog: Clicking template or parameter name scrolls it to top of dialog
		Resolved		awight	T289049 Disconnect old sidebar from VE template dialog
		Resolved		awight	T307188 Clean up feature flags except for new transclusion dialog sidebar
		Resolved		WMDE-Fisch	T310859 Remove dead code outside the transclusionDialogNewSidebar flag
		Resolved		awight	T310865 Temporarily fork the BookletLayout class
		Resolved		awight	T310866 Remove outlineSelectWidget from forked BookletLayout
		Resolved		awight	T311296 Decouple forked OutlineControlsWidget from OutlineSelectWidget and merge in our customizations
		Resolved		lilients_WMDE	T311223 Fork OutlineControlsWidget
		Resolved		awight	T310867 Cleanup: Hide knowledge about bookletLayout children
		Resolved		thiemowmde	T310868 Rename template dialog "pocSidebar"
		Invalid		None	T310869 Simplify sidebar panel layout
		Resolved		thiemowmde	T311069 Cleanup: Push sidebar down into TwoPaneTransclusionDialogLayout

Event Timeline

awight created this task.Aug 17 2021, 10:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2021, 10:46 AM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Aug 17 2021, 4:42 PM

thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 14 2022, 2:38 PM

thiemowmde moved this task from Incoming to Needs discussion or investigation on the WMDE-TechWish-Maintenance board.Jan 17 2022, 2:48 PM

thiemowmde added projects: Epic, Technical-Debt.Jan 20 2022, 2:16 PM

WMDE-Fisch added a parent task: T299036: VE Dialog: Clicking template or parameter name scrolls it to top of dialog.Jan 20 2022, 2:16 PM

WMDE-Fisch added a parent task: T299490: Add shortcuts to hover tooltips on buttons in adv toolbar.Jan 24 2022, 12:21 PM

Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.May 17 2022, 2:24 PM

WMDE-Fisch moved this task from In preparation to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 7 2022, 11:12 AM

awight added a subtask: T307188: Clean up feature flags except for new transclusion dialog sidebar.Jun 7 2022, 11:16 AM

awight mentioned this in T307188: Clean up feature flags except for new transclusion dialog sidebar.Jun 10 2022, 3:37 PM

awight added a parent task: T290975: Synchronize scroll and focus when template dialog is in narrow-screen mode.Jun 15 2022, 9:31 AM

Change 806238 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove obsolete "search for a parameter" page and widgets

https://gerrit.wikimedia.org/r/806238

gerritbot added a project: Patch-For-Review.Jun 16 2022, 3:57 PM

Change 806240 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Force "new template dialog sidebar" feature flag to be true

https://gerrit.wikimedia.org/r/806240

Change 806240 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Force "new template dialog sidebar" feature flag to be true

https://gerrit.wikimedia.org/r/806240

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 17 2022, 8:00 AM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-08.Jun 17 2022, 8:08 AM

WMDE-Fisch moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2022-06-08 board.

WMDE-Fisch removed a project: Patch-For-Review.Jun 17 2022, 8:28 AM

awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Jun 17 2022, 9:10 AM

awight closed subtask T310869: Simplify sidebar panel layout as Invalid.Jun 21 2022, 12:24 PM

awight closed subtask T307188: Clean up feature flags except for new transclusion dialog sidebar as Resolved.

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-22.Jun 22 2022, 8:08 AM

Tobi_WMDE_SW moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 22 2022, 8:11 AM

thiemowmde closed subtask T310868: Rename template dialog "pocSidebar" as Resolved.Jun 22 2022, 8:20 AM

awight closed subtask T310865: Temporarily fork the BookletLayout class as Resolved.Jun 23 2022, 10:44 AM

awight closed subtask T310867: Cleanup: Hide knowledge about bookletLayout children as Resolved.Jul 4 2022, 1:55 PM

awight closed subtask T311069: Cleanup: Push sidebar down into TwoPaneTransclusionDialogLayout as Resolved.

awight closed subtask T310859: Remove dead code outside the transclusionDialogNewSidebar flag as Resolved.

awight closed subtask T310866: Remove outlineSelectWidget from forked BookletLayout as Resolved.

awight closed this task as Resolved.Jul 4 2022, 1:58 PM

awight claimed this task.

awight moved this task from Watching / Epic / Stalled to Done on the WMDE-TechWish-Sprint-2022-06-22 board.