Page MenuHomePhabricator

Remove compatConfig from Vue settings
Open, Needs TriagePublic

Description

Once we've switched from the migration build of Vue 3 to the regular build of Vue 3, the compatConfig settings in component definitions will be ignored, and we should remove them.

Code search: https://codesearch.wmcloud.org/things/?q=compatConfig

[ ] Extension:ContentTranslation (1 files)

What needs to be done:
For all the extension repositories left (ContentTranslation, SearchVue, Wikibase) go to the files mentioned under each one, remove all instances of compactConfig

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/ContentTranslationmaster+0 -2
mediawiki/extensions/SearchVuemaster+0 -15
mediawiki/extensions/Wikibasemaster+1 -38
mediawiki/extensions/CheckUsermaster+0 -12
mediawiki/skins/Cosmosmaster+0 -3
mediawiki/extensions/GrowthExperimentsmaster+0 -44
mediawiki/skins/Vectormaster+0 -3
mediawiki/extensions/ReadingListsmaster+0 -6
mediawiki/extensions/QuickSurveysmaster+0 -6
mediawiki/extensions/NearbyPagesmaster+0 -6
mediawiki/extensions/GrowthExperimentsmaster+3 K -3 K
mediawiki/extensions/ContentTranslationmaster+6 K -12 K
mediawiki/extensions/ContentTranslationmaster+1 -11
mediawiki/extensions/ContentTranslationmaster+0 -4
mediawiki/extensions/WikiLovemaster+0 -3
mediawiki/extensions/FileImportermaster+0 -6
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Web team extensions now tracked in T363351

TheDJ subscribed.

This seems like a well defined task suited for good first task

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Pppery changed the task status from In Progress to Open.Nov 11 2024, 5:22 AM

Change #1095204 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/NearbyPages@master] NearbyPages: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1095204

Change #1096747 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1096747

Once we've switched from the migration build of Vue 3 to the regular build of Vue 3, the compatConfig settings in component definitions will be ignored, and we should remove them.

Probably should have checked this already, but wanted to clarify. The task description makes it sound like switching from the migration build of Vue 3 to the regular build of Vue 3 will happen in the future. But this already happened, right? (link to task/patch?) So all the removals identified in the task description are good to go? cc @CCiufo-WMF

Change #1095204 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] NearbyPages: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1095204

Change #1096747 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1096747

Change #1097423 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/ReadingLists@master] ReadingLists: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097423

Change #1097423 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] ReadingLists: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097423

Change #1097485 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/skins/Vector@master] Vector: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097485

Change #1097485 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097485

Change #1097587 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/skins/Cosmos@master] Cosmos: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097587

Change #1108394 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] vue: Remove compatConfig settings after Vue 3 migration

https://gerrit.wikimedia.org/r/1108394

Change #1108394 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] vue: Remove compatConfig settings after Vue 3 migration

https://gerrit.wikimedia.org/r/1108394

(I'm removing this from Growth boards. As far as I can tell, everything on our end has been taking care of. Feel free to re-add tags if I missed anything.)

Ddshelto subscribed.

Change #1097587 merged by Universal Omega:

[mediawiki/skins/Cosmos@master] Cosmos: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1097587

Change #1135048 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/CheckUser@master] CheckUser: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1135048

Change #1135048 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] CheckUser: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1135048

Not sure what's going on with the CX codesearch results. compatConfig was actually removed a while back from the source and vite configuration but it is still being outputted in the build. Other than being not needed, does it have any adverse effect?

Change #1135749 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/Wikibase@master] Wikibase: Remove compatConfig from Vue settings

https://gerrit.wikimedia.org/r/1135749

Change #1135749 abandoned by Seawolf35gerrit:

[mediawiki/extensions/Wikibase@master] Wikibase: Remove compatConfig from Wikidata Data Bridge

Reason:

broken

https://gerrit.wikimedia.org/r/1135749

Change #1135749 restored by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Wikibase: Remove compatConfig from Wikidata Data Bridge

https://gerrit.wikimedia.org/r/1135749

Change #1135749 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] bridge: Wikibase: Remove compatConfig from Wikidata Data Bridge

https://gerrit.wikimedia.org/r/1135749

Change #1196976 had a related patch set uploaded (by LazyShrey; author: LazyShrey):

[mediawiki/extensions/ContentTranslation@master] ContentTranslation: Remove compatConfig from Vue components

https://gerrit.wikimedia.org/r/1196976

Change #1196977 had a related patch set uploaded (by LazyShrey; author: LazyShrey):

[mediawiki/extensions/SearchVue@master] ContentTranslation: Remove compatConfig from Vue components

https://gerrit.wikimedia.org/r/1196977

Change #1196977 abandoned by Aklapper:

[mediawiki/extensions/SearchVue@master] ContentTranslation: Remove compatConfig from Vue components

Reason:

This is an exact copy of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SearchVue/+/1122674 . Creating duplicates on purpose makes no sense and is not a good use of anybody's time.

https://gerrit.wikimedia.org/r/1196977

Change #1196976 abandoned by Nikerabbit:

[mediawiki/extensions/ContentTranslation@master] ContentTranslation: Remove compatConfig from Vue components

Reason:

Automatically generated files should not be modified manually.

https://gerrit.wikimedia.org/r/1196976

Hi! I’d like to work on this task and handle the removal of compactConfig from the Vue settings files listed above.
Please let me know if that sounds good.