We no longer use the Start module and its base task modules, but keeping its code around isn't free (see e.g. {T289066}). So let's remove the code, and we can restore it later if we decide it's necessary.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
), so I am proposing to remove the code in the patch attached to this task. The code could be restored later if we decide we want to pursue it again, but as it stands now, it is just extra lines of code to scan when we need to e.g. assess our code for security vulnerabilities.
@RHo @MMiller_WMF As far as I know we have no plans to continue work on the old start module (
Comment Actions
Change 713605 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Remove Start module and references to it
Comment Actions
@RHo @MMiller_WMF As far as I know we have no plans to continue work on the old start module (
), so I am proposing to remove the code in the patch attached to this task. The code could be restored later if we decide we want to pursue it again, but as it stands now, it is just extra lines of code to scan when we need to e.g. assess our code for security vulnerabilities.
SGTM @kostajh, thanks for the heads up
Comment Actions
Change 713878 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Homepage: Remove BaseTaskModules
Comment Actions
Change 713878 abandoned by Kosta Harlan:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Remove task modules
Reason:
squashed
Comment Actions
Change 713605 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Remove Start module and task modules