Page MenuHomePhabricator

Bundle WikiEditor extension with MediaWiki
Closed, ResolvedPublic

Description

Once a few remaining issues are resolved, the new WikiEditor developed as part of the Usability Initiative should be folded into the MediaWiki core to replace the old "monobook toolbar".


Version: unspecified
Severity: enhancement

Details

Reference
bz26914

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:22 PM
bzimport set Reference to bz26914.
bzimport added a subscriber: Unknown Object (MLST).

See also 26750 comment 3 and further down.

WikiEditor was moved from /trunk/extensions/UsabilityInitiative/WikiEditor to /trunk/extensions/WikiEditor (making it its own extension) in r73054.

There is a large debate in the code comments of r73030 (where Vector was moved from /trunk/extensions/UsabilityInitiative/Vector to /trunk/extensions/Vector) regarding whether keeping some of this functionality in extensions is a good idea. There's additional discussion on the wikitech-l mailing list: http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/50223

There seem to be divergent theories about how much code/functionality should be in MediaWiki core and how much code/functionality should be in extensions.

All of this is said without re-expressing my opinion on this issue, but whoever tries to resolve this bug should be warned that doing so may have unexpected consequences.

Broadly speaking I would recommend:

  1. keep WikiEditor as an extension
  2. migrate the *old* toolbar to an extension too (leaving just a plain textarea as the extensionless version)
  3. ship WikiEditor extension on by default with MediaWiki
  4. make sure there's a fairly clean interface for plugging in other alternate editor frontends

I really have no strong opinion on this. I just created this bug to keep Bug 26750 from getting derailed. Feel free to close as WONTFIX if it does not appear there is consensus for this.

(In reply to comment #4)

Broadly speaking I would recommend:

  1. keep WikiEditor as an extension
  2. migrate the *old* toolbar to an extension too (leaving just a plain textarea

as the extensionless version)

  1. ship WikiEditor extension on by default with MediaWiki
  2. make sure there's a fairly clean interface for plugging in other alternate

editor frontends

Sounds good to me.

Created bug 26918 for point 4 by the way.

updated summary. Now, to create that clean interface.

  • Removing blockage to bug 26751 ("Extensions that should really be core functionality"), since we're probably going to bundle this by using the new installer.
  • Adding dependancy on bug 26918

moejoe0000 wrote:

I post here because it is for me much related:

I was just installing WikiEditor bundled with MediaWiki tarball and activating the extension in the installer. Unfortunately, this does not help much because WikiEditor is by default disabled which requires to modify LocalSettings.php manually.

At a first place this may be confusing as the installer claims that checking the checkbox is sufficient.

Before bundeling one had to download WikiEditor seperately which forced the user to read [[mw:Extension:WikiEditor]] where the (correct) installation process is explained. Now nobody forces the user to read that anymore.

Would is not be rasonable also to enable WikiEditor if somebody tells the installer that it shall be installed? (Maybe changing the defaults of WikiEditor?)

Marking fixed as the actual bug is...

(In reply to comment #11)

I post here because it is for me much related:

I was just installing WikiEditor bundled with MediaWiki tarball and activating
the extension in the installer. Unfortunately, this does not help much because
WikiEditor is by default disabled which requires to modify LocalSettings.php
manually.

At a first place this may be confusing as the installer claims that checking
the checkbox is sufficient.

Before bundeling one had to download WikiEditor seperately which forced the
user to read [[mw:Extension:WikiEditor]] where the (correct) installation
process is explained. Now nobody forces the user to read that anymore.

Would is not be rasonable also to enable WikiEditor if somebody tells the
installer that it shall be installed? (Maybe changing the defaults of
WikiEditor?)

See also bug 31279