Maniphest T289155

Don't show back link for invalid languages
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Aug 18 2021, 1:43 PM

Tags

Referenced Files

None

Subscribers

Description

A link such as https://ws-export.wmcloud.org/?lang=foo&format=epub&page=Lorem_ipsum results in a 'Back to Wikisource' link that goes to https://foo.wikisource.org/wiki/Lorem%20ipsum . This should be fixed.

If an invalid language is passed, no back link should be shown.

Related Objects

Mentioned In: T269956: Wikibooks EN export not working: Could not resolve host: en-wikibooks.wikisource.org

Event Timeline

Samwilson created this task.Aug 18 2021, 1:43 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 18 2021, 1:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwilson mentioned this in T269956: Wikibooks EN export not working: Could not resolve host: en-wikibooks.wikisource.org.Aug 18 2021, 1:58 PM

ldelench_wmf moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 30 2021, 3:12 PM

ldelench_wmf added a project: Technical-Debt.

ldelench_wmf set the point value for this task to 2.Sep 9 2021, 5:24 PM

ldelench_wmf moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.

Billinghurst renamed this task from Don't show back link for invalid langauges to Don't show back link for invalid languages.Sep 10 2021, 1:12 AM

@Samwilson Does this work? https://github.com/wikimedia/ws-export/pull/390

Merged, and released in version 2.9.3.

Thanks Alex!

Happy to help. Thanks for getting it over the finish line!