Page MenuHomePhabricator
Create Task
Maniphest T289160

Rename WikibaseRepo.FederatedProperties.entitytypes.php
Closed, ResolvedPublic
Actions

Description

This name doesn't really make sense because these aren't entitytypes. They're just services to override the property services in the event that we're trying to work with a FederatedProperty

Details

SubjectRepoBranchLines +/-
Rename WikibaseRepo.FederatedProperties.entitytypes.phpmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Event Timeline

Tarrow created this task.Aug 18 2021, 2:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2021, 2:32 PM
Rosalie_WMDE claimed this task.Aug 23 2021, 12:55 PM
Rosalie_WMDE moved this task from Tech Debt to Federation v2 - Sprint 5 on the Wikibase - Federated Properties board.
Rosalie_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 5); removed Wikibase - Federated Properties.
Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.
gerritbot added a comment.Aug 23 2021, 1:30 PM

Change 714361 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename WikibaseRepo.FederatedProperties.entitytypes.php

https://gerrit.wikimedia.org/r/714361

gerritbot added a project: Patch-For-Review.Aug 23 2021, 1:30 PM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.Aug 23 2021, 2:01 PM
gerritbot added a comment.Aug 26 2021, 8:26 AM

Change 714361 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename WikibaseRepo.FederatedProperties.entitytypes.php

https://gerrit.wikimedia.org/r/714361

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.Aug 26 2021, 8:40 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 9:10 AM
Tarrow closed this task as Resolved.Sep 1 2021, 9:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL