Page MenuHomePhabricator

doc.wm.o says "empty directory" for non-empty demos directory
Closed, ResolvedPublic

Description

Ref https://doc.wikimedia.org/VisualEditor/master/js/lib/ve/demos/ve/.

This directory contains HTML files (source), but it seems the file index only supports sub directories at the moment (and skips over this, redirecting to pages/). This makes sense historally since the first three levels of navigation on this domain are all index-based:

  1. by software directory: goes to a standalone microsite with an index, or sub directories for different releases.
  2. by release directory: goes to a standalone microsite with an index, or sub directories for different reports.
  3. by report: e.g. JS doc, PHP doc, demo.

What we haven't covered for is a static file output that doesn't have its own index to list the contents, which is the case here.

Event Timeline

Change 713698 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/docroot@master] doc: Support listing files on index pages

https://gerrit.wikimedia.org/r/713698

Krinkle triaged this task as Medium priority.Aug 23 2021, 5:53 PM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
ppelberg added subscribers: DLynch, matmarex, ppelberg.

@Krinkle: thank you for filing and fixing. We're going to assume you have code review covered. Although, please ping @matmarex or @DLynch if that's not the case.

Change 713698 merged by jenkins-bot:

[integration/docroot@master] doc: Support listing files on index pages

https://gerrit.wikimedia.org/r/713698

Mentioned in SAL (#wikimedia-operations) [2021-09-02T09:55:53Z] <hashar@deploy1002> Started deploy [integration/docroot@973ac8a]: Support listing files on index pages - T289196

Mentioned in SAL (#wikimedia-operations) [2021-09-02T09:56:00Z] <hashar@deploy1002> Finished deploy [integration/docroot@973ac8a]: Support listing files on index pages - T289196 (duration: 00m 07s)

I have reviewed and deployed Timo fix. It might take up to an hour for the change to be reflected on doc.wikimedia.org due to frontend caching (we do not purge the cache content on deployment). Adding a query parameter to the URL does bypass the cache though and https://doc.wikimedia.org/VisualEditor/master/js/lib/ve/demos/ve/?cacheburst shows files being listed ;)

Change 717574 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/docroot@master] doc: Fix links to files in doc directories

https://gerrit.wikimedia.org/r/717574

Change 717574 merged by jenkins-bot:

[integration/docroot@master] doc: Fix links to files in doc directories

https://gerrit.wikimedia.org/r/717574