Uncaught TypeError when typing at end a line when page contains <ref> with heading
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Aug 18 2021, 9:16 PM

Description

Open https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet and edit in VE.
Scroll to "GLaDOS was making a note here." and click after the end of this to place the cursor.
Type a full stop (.)

Actual result:

Uncaught TypeError: this.root is null
    onSetup :1147
    emit jQuery
    setLive :444
    setLive :455
    setLive :455
    updatePreview :847
    setModel :846
    setModel :1122
    VeUiPreviewElement :846
    VeUiMwPreviewElement

That page is quite large, so I narrowed it down to this minimal test case

Details

	Subject	Repo	Branch	Lines +/-
	ve.ce.MWHeadingNode: Fix Uncaught TypeError: this.root is null	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Event Timeline

Krinkle created this task.Aug 18 2021, 9:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2021, 9:16 PM

Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 18 2021, 9:16 PM

Maintenance_bot added a project: VisualEditor.Aug 18 2021, 9:45 PM

Change 715076 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] ve.ce.MWHeadingNode: Fix Uncaught TypeError: this.root is null

https://gerrit.wikimedia.org/r/715076

gerritbot added a project: Patch-For-Review.Aug 26 2021, 7:35 PM

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Aug 26 2021, 7:36 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Change 715076 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ve.ce.MWHeadingNode: Fix Uncaught TypeError: this.root is null

https://gerrit.wikimedia.org/r/715076

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 28 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2021, 4:10 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 30 2021, 10:01 PM

matmarex added a project: Editing QA.

Ryasmeen edited projects, added Verified; removed Editing QA.Sep 2 2021, 8:29 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Sep 4 2021, 12:32 AM

ppelberg claimed this task.

Uncaught TypeError when typing at end a line when page contains <ref> with headingClosed, ResolvedPublicActions

Description

Details

Event Timeline

Uncaught TypeError when typing at end a line when page contains <ref> with heading
Closed, ResolvedPublic
Actions