Page MenuHomePhabricator
Create Task
Maniphest T289226

Convert EasyTimeline extension to use Shellbox
Open, Needs TriagePublic
Actions

Description

The Timeline extension shells out to a Perl script, which invokes ploticus. EasyTimeline.pl is a 5k-line Perl script, one question is whether we should stick that in the Shellbox container or send it as part of each request as a script.

Also the fonts are currently in the operations/mediawiki-config/fonts repository, it's unclear whether all of them are needed, or just the ones configured in https://noc.wikimedia.org/conf/highlight.php?file=timeline.php

  • Review charts
  • shellbox-timeline namespaces in k8s
  • shellbox-timeline accounts in k8s.
  • shellbox-timeline puppet private tokens.
  • Generate TLS certificates
  • Review helmfile.d files:
  • LVS setup
  • DNS for LVS records
  • Discovery DNS
  • Monitoring dashboard
  • Integration and Acceptance tests

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Aug 19 2021, 1:51 AM
gerritbot added a comment.Aug 26 2021, 6:11 AM

Change 714883 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/timeline@master] [WIP] Migrate to BoxedCommand, copy structure from Score

https://gerrit.wikimedia.org/r/714883

gerritbot added a project: Patch-For-Review.Aug 26 2021, 6:11 AM
gerritbot added a comment.Aug 26 2021, 6:24 AM

Change 714885 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/libs/Shellbox@master] [WIP] pipeline: Add configuration for Timeline image

https://gerrit.wikimedia.org/r/714885

Legoktm claimed this task.Aug 26 2021, 10:46 PM
gerritbot added a comment.Sep 1 2021, 4:04 PM

Change 714885 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] pipeline: Add configuration for Timeline image

https://gerrit.wikimedia.org/r/714885

Legoktm updated the task description. (Show Details)Sep 1 2021, 9:33 PM
gerritbot added a comment.Sep 1 2021, 9:59 PM

Change 716048 had a related patch set uploaded (by Legoktm; author: Legoktm):

[labs/private@master] Add k8s users/tokens for shellbox-{syntaxhighlight,timeline}

https://gerrit.wikimedia.org/r/716048

gerritbot added a comment.Sep 1 2021, 10:03 PM

Change 716051 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] Add k8s tokens/users for shellbox-{syntaxhighlight,timeline}

https://gerrit.wikimedia.org/r/716051

gerritbot added a comment.Sep 1 2021, 10:16 PM

Change 716048 merged by Legoktm:

[labs/private@master] Add k8s users/tokens for shellbox-{syntaxhighlight,timeline}

https://gerrit.wikimedia.org/r/716048

gerritbot added a comment.Sep 1 2021, 10:16 PM

Change 716051 merged by Legoktm:

[operations/puppet@production] Add k8s users/tokens for shellbox-{syntaxhighlight,timeline}

https://gerrit.wikimedia.org/r/716051

gerritbot added a comment.Sep 1 2021, 10:20 PM

Change 716055 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/deployment-charts@master] admin: Add namespace for shellbox-timeline

https://gerrit.wikimedia.org/r/716055

Legoktm mentioned this in rLPRI4123326114eb: Add k8s users/tokens for shellbox-{syntaxhighlight,timeline}.Sep 1 2021, 10:24 PM
gerritbot added a comment.Sep 1 2021, 10:27 PM

Change 716055 merged by jenkins-bot:

[operations/deployment-charts@master] admin: Add namespace for shellbox-timeline

https://gerrit.wikimedia.org/r/716055

gerritbot added a comment.Sep 1 2021, 10:50 PM

Change 716063 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/deployment-charts@master] Add helmfile.d for shellbox-timeline

https://gerrit.wikimedia.org/r/716063

Legoktm updated the task description. (Show Details)Sep 1 2021, 11:07 PM
gerritbot added a comment.Sep 1 2021, 11:13 PM

Change 716063 merged by jenkins-bot:

[operations/deployment-charts@master] Add helmfile.d for shellbox-timeline

https://gerrit.wikimedia.org/r/716063

Legoktm updated the task description. (Show Details)Sep 1 2021, 11:30 PM
Legoktm mentioned this in T290686: Code Stewardship Review: EasyTimeline.Sep 11 2021, 1:49 AM
Legoktm mentioned this in T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.Sep 11 2021, 1:57 AM
gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721904 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] Add LVS for new Shellboxes: media, syntaxhighlight & timeline

https://gerrit.wikimedia.org/r/721904

gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721905 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] service: Switch new Shellboxes to lvs_setup

https://gerrit.wikimedia.org/r/721905

gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721906 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] service: Switch new Shellboxes to monitoring_setup

https://gerrit.wikimedia.org/r/721906

gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721908 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/dns@master] Add *.svc.{codfw,eqiad}.wmnet entries for new Shellboxes

https://gerrit.wikimedia.org/r/721908

gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721907 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] service: Switch new Shellboxes to production

https://gerrit.wikimedia.org/r/721907

gerritbot added a comment.Sep 17 2021, 10:03 PM

Change 721909 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/dns@master] Add new Shellboxes to discovery

https://gerrit.wikimedia.org/r/721909

gerritbot added a comment.Sep 21 2021, 5:15 PM

Change 714883 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Migrate to BoxedCommand, copy structure from Score

https://gerrit.wikimedia.org/r/714883

gerritbot added a comment.Sep 22 2021, 4:45 AM

Change 721908 merged by Legoktm:

[operations/dns@master] Add *.svc.{codfw,eqiad}.wmnet entries for new Shellboxes

https://gerrit.wikimedia.org/r/721908

gerritbot added a comment.Sep 22 2021, 4:54 AM

Change 721904 merged by Legoktm:

[operations/puppet@production] Add LVS for new Shellboxes: media, syntaxhighlight & timeline

https://gerrit.wikimedia.org/r/721904

gerritbot added a comment.Sep 22 2021, 5:11 AM

Change 721905 merged by Legoktm:

[operations/puppet@production] service: Switch new Shellboxes to lvs_setup

https://gerrit.wikimedia.org/r/721905

gerritbot added a comment.Sep 22 2021, 5:33 AM

Change 721906 merged by Legoktm:

[operations/puppet@production] service: Switch new Shellboxes to monitoring_setup

https://gerrit.wikimedia.org/r/721906

gerritbot added a comment.Sep 22 2021, 5:41 AM

Change 721907 merged by Legoktm:

[operations/puppet@production] service: Switch new Shellboxes to production

https://gerrit.wikimedia.org/r/721907

gerritbot added a comment.Sep 22 2021, 5:45 AM

Change 721909 merged by Legoktm:

[operations/dns@master] Add new Shellboxes to discovery

https://gerrit.wikimedia.org/r/721909

gerritbot added a comment.Sep 22 2021, 5:56 AM

Change 722736 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/puppet@production] services_proxy: Add envoy proxies for new Shellboxes

https://gerrit.wikimedia.org/r/722736

gerritbot added a comment.Sep 22 2021, 5:58 AM

Change 722737 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/mediawiki-config@master] ProductionServices: Add new Shellboxes

https://gerrit.wikimedia.org/r/722737

gerritbot added a comment.Sep 22 2021, 6:02 AM

Change 722736 merged by Legoktm:

[operations/puppet@production] services_proxy: Add envoy proxies for new Shellboxes

https://gerrit.wikimedia.org/r/722736

gerritbot added a comment.Sep 22 2021, 6:05 PM

Change 722737 merged by jenkins-bot:

[operations/mediawiki-config@master] ProductionServices: Add new Shellboxes

https://gerrit.wikimedia.org/r/722737

Legoktm updated the task description. (Show Details)Sep 23 2021, 7:41 AM
gerritbot added a comment.Sep 25 2021, 12:53 AM

Change 723651 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/mediawiki-config@master] Set $wgTimelineFonts and send all Timeline generation to Shellbox

https://gerrit.wikimedia.org/r/723651

gerritbot added a comment.Sep 27 2021, 9:16 PM

Change 723651 merged by jenkins-bot:

[operations/mediawiki-config@master] Set $wgTimelineFonts and send all Timeline generation to Shellbox

https://gerrit.wikimedia.org/r/723651

Stashbot added a comment.Sep 27 2021, 9:18 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-27T21:18:55Z] <legoktm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Set $wgTimelineFonts and send all Timeline generation to Shellbox (T289226) (1/2) (duration: 00m 56s)

Stashbot added a comment.Sep 27 2021, 9:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-27T21:20:10Z] <legoktm@deploy1002> Synchronized wmf-config/CommonSettings.php: Set $wgTimelineFonts and send all Timeline generation to Shellbox (T289226) (2/2) (duration: 00m 56s)

gerritbot added a comment.Sep 30 2021, 7:30 PM

Change 725097 had a related patch set uploaded (by Legoktm; author: Legoktm):

[operations/deployment-charts@master] Throw more resources at shellbox-timeline

https://gerrit.wikimedia.org/r/725097

gerritbot added a comment.Sep 30 2021, 7:36 PM

Change 725097 merged by jenkins-bot:

[operations/deployment-charts@master] Throw more resources at shellbox-timeline

https://gerrit.wikimedia.org/r/725097

Legoktm added a comment.Oct 4 2021, 4:20 PM

This is done \o/, just some cleanup left to do before resolving it.

VulpesVulpes825 added a subtask: T293050: Characters are missing in the chart of EasyTimeline on zhwiki.Oct 20 2021, 5:41 PM
VulpesVulpes825 added a subtask: T274822: [EasyTimeline] No text included / no font rendered / displayed at all in PNG graph output.
Legoktm closed subtask T293050: Characters are missing in the chart of EasyTimeline on zhwiki as Resolved.Oct 21 2021, 7:49 PM
Od1n added a subscriber: Od1n.Nov 11 2021, 10:06 PM

Refs T216318, where I had submitted a patch (see changeset 6) to implement width and height attributes, with a sidecar file for faster subsequent retrievals of their values.

Maybe someone would be interested in rebasing it…

Legoktm mentioned this in T317227: Phonos should have its own shellbox deployment for production.Sep 7 2022, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL