Remove line between My Collections and Available Collections in My Library
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwalton9-WMF
	Aug 19 2021, 1:00 PM

Description

A user reported that the line between My Collections and Available Collections is confusing.

The "My collections" tab button has a little line to the right, is this intentional?

Looking at other tab systems for inspiration shows that this isn't a commonly used element. Instead, we should remove this line and shorten the underline a little to distinguish the two selections from each other.

Twitter notifications (All selected, Mentions highlighted)

Asana (List selected, Board highlighted)

Facebook (Home selected, Pages highlighted)

Related Objects

Mentioned In: T290245: Allow users to filter for searchable status

Event Timeline

Samwalton9-WMF created this task.Aug 19 2021, 1:00 PM

Samwalton9-WMF mentioned this in T290245: Allow users to filter for searchable status.Sep 7 2021, 9:55 AM

Ajay47 claimed this task.Sep 7 2021, 10:05 AM

Hi @Samwalton9, I have raised a PR for this at https://github.com/WikipediaLibrary/TWLight/pull/806.

Samwalton9-WMF triaged this task as Lowest priority.Sep 7 2021, 12:34 PM

Samwalton9-WMF edited projects, added The-Wikipedia-Library (Kanban); removed The-Wikipedia-Library.

Samwalton9-WMF moved this task from Ready to Review on the The-Wikipedia-Library (Kanban) board.

Hi @Samwalton9, Yesterday I had raised the PR for this but I had forgotten to add a feature (to shorten the underline). Now I want to know that how much short underline we want? I also add some example navigation for design perspective, which one should I apply?

[1] https://akayjoshi.github.io/nav1/
[2] https://akayjoshi.github.io/nav2/

Hi Ajay - this is great, thanks for catching this. I think nav2 is my preferred option in terms of design, and I think the width could be something like 80% of the text width.

Okay, thanks.

Samwalton9-WMF moved this task from Review to In Progress on the The-Wikipedia-Library (Kanban) board.Sep 8 2021, 2:04 PM

Samwalton9-WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.Sep 9 2021, 11:59 AM

Hi @Samwalton9, I have updated the changes on PR, now it can be merge.

Samwalton9-WMF moved this task from In Progress to Review on the The-Wikipedia-Library (Kanban) board.Sep 13 2021, 8:09 AM

Scardenasmolinar moved this task from Review to Reviewed (waiting for changes) on the The-Wikipedia-Library (Kanban) board.Sep 13 2021, 11:24 PM

Samwalton9-WMF moved this task from Reviewed (waiting for changes) to Review on the The-Wikipedia-Library (Kanban) board.Sep 15 2021, 9:36 AM