Page MenuHomePhabricator

images not loading from TU-154 polish wiki article
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

a black background appears

What should have happened instead?:
the images of the article should appear

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

also happens for http://127.0.0.1:8080/#/article/eo/Koldkremo , could it be that the issue is a regression since the name of the test case that fails is

gallery opens from a non-english article

?

hueitan added a subscriber: hueitan.

adding Wikipedia-Preview tag, same error too, since we use the same endpoint params.

When checking on https://wikimedia.github.io/wikipedia-preview/demo/articles/arabic.html,
the second and third links gallery have the same problem.

hueitan moved this task from Backlog to Kanban on the Inuka-Team board.
hueitan edited projects, added Inuka-Team (Kanban); removed Inuka-Team.
hueitan moved this task from Backlog to Dev on the Inuka-Team (Kanban) board.

This commit isn't relevant.

Relevant Ticket: T248611#6020386, the logic to choose the image between commons / wikipedia isn't always true now

Based on my understanding, Wikipedia uses CommonsMetadata extension, the imageinfo api is enough for us to have all the information License|LicenseShortName|ImageDescription|Artist

Wikipedia KaiOS PR: https://github.com/wikimedia/wikipedia-kaios/pull/377
Wikipedia Preview PR: https://github.com/wikimedia/wikipedia-preview/pull/142

Please test it carefully in different articles, different languages

SBisson added a subscriber: SBisson.

Code looks good. It is just always calling the wiki instead of commons.

@Jpita please test carefully and merge as appropriate.