Page MenuHomePhabricator
Create Task
Maniphest T289288

FileImporter: PHP Notice: Undefined index: size
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: size
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(329)
#0 /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(329): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php(176): FileImporter\Remote\MediaWiki\ApiDetailRetriever->checkMaxRevisionAggregatedBytes(array)
#2 /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/Services/SourceSite.php(81): FileImporter\Remote\MediaWiki\ApiDetailRetriever->getImportDetails(FileImporter\Data\SourceUrl)
#3 /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/SpecialImportFile.php(311): FileImporter\Services\SourceSite->retrieveImportDetails(FileImporter\Data\SourceUrl)
#4 /srv/mediawiki/php-1.37.0-wmf.19/extensions/FileImporter/src/SpecialImportFile.php(229): FileImporter\SpecialImportFile->makeImportPlan(WebRequest)
#5 /srv/mediawiki/php-1.37.0-wmf.19/includes/specialpage/SpecialPage.php(646): FileImporter\SpecialImportFile->execute(NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.19/includes/specialpage/SpecialPageFactory.php(1365): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.37.0-wmf.19/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#8 /srv/mediawiki/php-1.37.0-wmf.19/includes/MediaWiki.php(925): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.37.0-wmf.19/includes/MediaWiki.php(559): MediaWiki->main()
#10 /srv/mediawiki/php-1.37.0-wmf.19/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.37.0-wmf.19/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}
Impact

Unclear.

Notes

These are happening at a very low rate - I looked back 2 weeks in logstash and found 8 instances.

Details

Request URL
https://commons.wikimedia.org/wiki/Special:ImportFile?clientUrl=*&importSource=*
SubjectRepoBranchLines +/-
Fix possible index error in ApiDetailRetrievermediawiki/extensions/FileImportermaster+4 -6
Customize query in gerrit

Related Objects

Event Timeline

brennen renamed this task from PHP Notice: Undefined index: size to FileImporter: PHP Notice: Undefined index: size.Aug 19 2021, 6:57 PM
brennen created this task.
brennen mentioned this in T281160: 1.37.0-wmf.19 deployment blockers.Aug 19 2021, 11:14 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Aug 19 2021, 11:21 PM
WMDE-Fisch added subscribers: WMDE-Fisch, awight, thiemowmde.Aug 20 2021, 9:37 AM
WMDE-Fisch triaged this task as Medium priority.Aug 20 2021, 9:47 AM

Thanks for the report!

For context: This is coming from the preview step of a planed import. The only thing that should happen here is, that the preview can not be seen and the import can not be started. So no dramatic effects and no unrecoverable inconsistencies.

We will look into this but not with the highest priority.

gerritbot added a comment.Aug 20 2021, 10:28 AM

Change 714028 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Fix possible index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/714028

gerritbot added a project: Patch-For-Review.Aug 20 2021, 10:28 AM
thiemowmde claimed this task.Aug 20 2021, 10:30 AM
thiemowmde set the point value for this task to 1.
thiemowmde moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.
thiemowmde added a project: Unplanned-Sprint-Work.

Turned out to be more trivial than expected. I don't think this needs further investigation.

awight added a project: WMDE-TechWish-Sprint-2021-08-18.Aug 20 2021, 12:06 PM

Looks like this was intended to go into the current sprint.

awight moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-08-18 board.Aug 20 2021, 12:06 PM
gerritbot added a comment.Aug 20 2021, 12:25 PM

Change 714028 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Fix possible index error in ApiDetailRetriever

https://gerrit.wikimedia.org/r/714028

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 20 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2021, 1:10 PM
thiemowmde moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-08-18 board.Aug 23 2021, 7:43 AM
Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 24 2021, 9:54 PM
thiemowmde closed this task as Resolved.Aug 31 2021, 8:32 AM
thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-08-18 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL