Page MenuHomePhabricator

Remove code for Settings swipe functionality
Closed, ResolvedPublic

Description

Remove code from: https://phabricator.wikimedia.org/T217937

Because of bug: https://phabricator.wikimedia.org/T287772

In the next release, we'll add this back in, with bug fixed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JMinor lowered the priority of this task from High to Low.Sep 3 2021, 5:25 PM

PR needs to be merged into 6.8.2 branch.

@Mazevedo

  1. Please remove the code added in https://github.com/wikimedia/wikipedia-ios/pull/3999.
  2. Add your name to the app contributors list in alphabetical order in Code/AboutViewController.plist, confirm you see your name in app Settings > About the app screen.

Open pull request, to be merged into our 6.8.2 release branch. Add a link to your pull request as a comment here.

This comment was removed by Mazevedo.
Tsevener moved this task from Needs Code Review to Needs QA on the iOS-app-v6.8.2 board.

Since this task was mainly reverting some code, there's nothing for QA to test, so I'm moving this directly to PM signoff.

New fix implemented as a part of https://phabricator.wikimedia.org/T217937, so I'm closing this task.