Page MenuHomePhabricator
Create Task
Maniphest T289297

PHP Notice: Undefined property: Wikimedia\RequestTimeout\RequestTimeoutException::$code
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined property: Wikimedia\RequestTimeout\RequestTimeoutException::$code
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.19/includes/debug/logger/monolog/LogstashFormatter.php(229)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.19/includes/debug/logger/monolog/LogstashFormatter.php(229): Exception->getCode()
#2 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Formatter/NormalizerFormatter.php(169): MediaWiki\Logger\Monolog\LogstashFormatter->normalizeException(Wikimedia\RequestTimeout\RequestTimeoutException, integer)
#3 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Formatter/NormalizerFormatter.php(157): Monolog\Formatter\NormalizerFormatter->normalize(Wikimedia\RequestTimeout\RequestTimeoutException, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Formatter/NormalizerFormatter.php(157): Monolog\Formatter\NormalizerFormatter->normalize(array, integer)
#5 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Formatter/NormalizerFormatter.php(53): Monolog\Formatter\NormalizerFormatter->normalize(array)
#6 /srv/mediawiki/php-1.37.0-wmf.19/includes/debug/logger/monolog/LogstashFormatter.php(55): Monolog\Formatter\NormalizerFormatter->format(array)
#7 /srv/mediawiki/php-1.37.0-wmf.19/includes/debug/logger/monolog/CeeFormatter.php(19): MediaWiki\Logger\Monolog\LogstashFormatter->format(array)
#8 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Handler/AbstractProcessingHandler.php(40): MediaWiki\Logger\Monolog\CeeFormatter->format(array)
#9 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Handler/WhatFailureGroupHandler.php(33): Monolog\Handler\AbstractProcessingHandler->handle(array)
#10 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Logger.php(317): Monolog\Handler\WhatFailureGroupHandler->handle(array)
#11 /srv/mediawiki/php-1.37.0-wmf.19/vendor/monolog/monolog/src/Monolog/Logger.php(539): Monolog\Logger->addRecord(integer, string, array)
#12 /srv/mediawiki/php-1.37.0-wmf.19/includes/exception/MWExceptionHandler.php(697): Monolog\Logger->error(string, array)
#13 /srv/mediawiki/php-1.37.0-wmf.19/includes/exception/MWExceptionHandler.php(147): MWExceptionHandler::logException(Wikimedia\RequestTimeout\RequestTimeoutException, string)
#14 /srv/mediawiki/php-1.37.0-wmf.19/includes/exception/MWExceptionHandler.php(185): MWExceptionHandler::rollbackMasterChangesAndLog(Wikimedia\RequestTimeout\RequestTimeoutException, string)
#15 /srv/mediawiki/php-1.37.0-wmf.19/includes/exception/MWExceptionHandler.php(157): MWExceptionHandler::handleException(Wikimedia\RequestTimeout\RequestTimeoutException, string)
#16 [internal function]: MWExceptionHandler::handleUncaughtException(Wikimedia\RequestTimeout\RequestTimeoutException)
#17 {main}
Impact

Unclear.

Notes

Saw this and 2 other variants in 1.37.0-wmf.19, all from the same request.

Unsure if MediaWiki-Debug-Logger is an appropriate tag here.

Details

Request URL
https://ca.wikipedia.org/w/rest.php/ca.wikipedia.org/v3/page/pagebundle/[bundle]/[id]

Related Objects

Event Timeline

brennen created this task.Aug 19 2021, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2021, 8:12 PM
brennen mentioned this in T281160: 1.37.0-wmf.19 deployment blockers.Aug 19 2021, 11:14 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Aug 19 2021, 11:21 PM
Krinkle edited projects, added MediaWiki-libs-RequestTimeout, Platform Engineering; removed Observability-Logging, MediaWiki-Debug-Logger.Aug 20 2021, 3:14 AM
Krinkle subscribed.

The RequestTimeoutException class inherits the PHP built-in Exception class, its getCode() method, and its Exception->code property, which is set by the Exception constructor. As such it seems reasonable for core's debug logger (LogstashFormatter) to call this method.

It seems something is happening specifically with RequestTimeoutException that causes this property to not be set in certain rare cases. If we determine this to be unreproducible, however, then perhaps this is opcache (T245183).

Tagging PE as steward of wikimedia/request-timeout.

tstarling triaged this task as Low priority.Aug 24 2021, 9:52 PM
tstarling subscribed.

6 occurrences in the last 30 days -> low priority

Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 24 2021, 9:53 PM
Krinkle edited projects, added Performance-Team; removed Platform Engineering.Aug 22 2022, 1:14 PM
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Krinkle closed this task as Resolved.Oct 29 2022, 12:05 AM
Krinkle claimed this task.

Not seen in 90 days.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL