Page MenuHomePhabricator

Bug: page preview settings icon is too high in some cases
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

I can't figure out why/when this is happening, but sometimes the settings icon is appearing too high up on the page preview. It seems to be happening for all orientations (vertical, horizontal, no image).

image.png (297×733 px, 91 KB)

image.png (376×1 px, 453 KB)

image.png (400×806 px, 213 KB)

Event Timeline

This will possibly be fixed by the changes in T284643.

Change 714845 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Fix cog alignment

https://gerrit.wikimedia.org/r/714845

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/1a4a4e14c0/w/

alexhollender added a subscriber: cjming.

looks better. on vertical previews the cog needs to move 2px away from the edge of the preview:

Screen Shot 2021-08-31 at 2.34.25 PM.png (537×883 px, 58 KB)

What is a vertical preview? I can't tell from the screenshot and can't replicate the 2px issue you are seeing.
Could you please give me replication steps?

@Jdlrobson apologies, by vertical I mean portrait. I will use the standard "portrait" and "landscape" terms going forward.

replication steps:

  • go to the patch demo
  • hover the link hunter–gatherers
  • hover the cog
  • there should be 16px of spacing between the edge of the preview and the gray background of the cog, currently 14px

Screen Shot 2021-08-31 at 5.52.49 PM.png (480×414 px, 238 KB)

Got it and fixed in latest patchset.

Change 714845 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix cog alignment

https://gerrit.wikimedia.org/r/714845

Please design review https://doc.wikimedia.org/Popups/master/js/ui/ this time. Code is merged so please move to sign off if it all looks good or needs more work if more work is needed.