Page MenuHomePhabricator
Create Task
Maniphest T289369

Instrument mentor dashboard for views
Closed, ResolvedPublic
Actions

Description

Per T285813, we want to be able to answer the following questions:

  • how many visits does Special:MentorDashboard have?
  • how many different mentors visit Special:MentorDashboard?

In this task, this instrumentation should be implemented.

Details

SubjectRepoBranchLines +/-
Add mediawiki.mentor_dashboard.visit schemaoperations/mediawiki-configmaster+6 -0
Instrument Special:MentorDashboardmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.20+30 -0
Fix mediawiki.mentor_dashboard.visit's definition #2operations/mediawiki-configmaster+1 -1
Fix schema definition for mediawiki.mentor_dashboard.visitoperations/mediawiki-configmaster+1 -1
Mentor dashboard instrumentation: Fix stream namemediawiki/extensions/GrowthExperimentsmaster+1 -1
Instrument Special:MentorDashboardmediawiki/extensions/GrowthExperimentsmaster+30 -0
Add analytics/mediawiki/mentor_dashboard/visitschemas/event/secondarymaster+264 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Aug 20 2021, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2021, 6:19 PM
Urbanecm_WMF triaged this task as Low priority.Aug 20 2021, 6:23 PM
gerritbot added a comment.Aug 20 2021, 6:26 PM

Change 714099 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[schemas/event/secondary@master] Add analytics/mediawiki/mentor_dashboard/visit

https://gerrit.wikimedia.org/r/714099

gerritbot added a project: Patch-For-Review.Aug 20 2021, 6:26 PM
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 20 2021, 6:29 PM
Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.Aug 20 2021, 6:32 PM
Urbanecm_WMF removed a project: Growth-Team-Filtering.Aug 24 2021, 7:34 PM
gerritbot added a comment.Aug 26 2021, 8:00 PM

Change 715108 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Instrument Special:MentorDashboard

https://gerrit.wikimedia.org/r/715108

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 27 2021, 10:57 AM
gerritbot added a comment.Aug 30 2021, 8:07 AM

Change 714099 merged by jenkins-bot:

[schemas/event/secondary@master] Add analytics/mediawiki/mentor_dashboard/visit

https://gerrit.wikimedia.org/r/714099

gerritbot added a comment.Aug 30 2021, 2:00 PM

Change 715108 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Instrument Special:MentorDashboard

https://gerrit.wikimedia.org/r/715108

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2021, 2:10 PM
gerritbot added a comment.Aug 30 2021, 2:49 PM

Change 715529 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Add mediawiki.mentor_dashboard.visit

https://gerrit.wikimedia.org/r/715529

gerritbot added a project: Patch-For-Review.Aug 30 2021, 2:49 PM
gerritbot added a comment.Aug 30 2021, 2:51 PM

Change 715530 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard instrumentation: Fix stream name

https://gerrit.wikimedia.org/r/715530

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 30 2021, 3:00 PM
gerritbot added a comment.Aug 30 2021, 6:28 PM

Change 715530 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentor dashboard instrumentation: Fix stream name

https://gerrit.wikimedia.org/r/715530

gerritbot added a comment.Aug 30 2021, 6:35 PM

Change 715529 merged by jenkins-bot:

[operations/mediawiki-config@master] Add mediawiki.mentor_dashboard.visit schema

https://gerrit.wikimedia.org/r/715529

gerritbot added a comment.Aug 30 2021, 6:47 PM

Change 715579 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Fix schema definition for mediawiki.mentor_dashboard.visit

https://gerrit.wikimedia.org/r/715579

Stashbot added a comment.Aug 30 2021, 6:49 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-30T18:49:22Z] <tgr@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: Revert: [[gerrit:715529|Add mediawiki.mentor_dashboard.visit schema (T289369)]] (duration: 00m 26s)

gerritbot added a comment.Aug 30 2021, 6:57 PM

Change 715579 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix schema definition for mediawiki.mentor_dashboard.visit

https://gerrit.wikimedia.org/r/715579

Stashbot added a comment.Aug 30 2021, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-30T19:06:22Z] <tgr@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:715579|Fix schema definition for mediawiki.mentor_dashboard.visit (T289369)]] (duration: 00m 56s)

gerritbot added a comment.Aug 30 2021, 7:48 PM

Change 715588 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Fix mediawiki.mentor_dashboard.visit's definition #2

https://gerrit.wikimedia.org/r/715588

gerritbot added a comment.Aug 30 2021, 7:50 PM

Change 715588 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix mediawiki.mentor_dashboard.visit's definition #2

https://gerrit.wikimedia.org/r/715588

Urbanecm_WMF moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.EditedAug 30 2021, 9:53 PM

So, I tested this in beta (via https://stream-beta.wmflabs.org/v2/ui/#/ and entering mediawiki.mentor_dashboard.visit there), and it appears to work! I'll likely backport the extension part later to test it at testwiki too (plus verify data lake received the data), and then I'll close it.

gerritbot added a comment.Aug 30 2021, 9:57 PM

Change 715610 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.20] Instrument Special:MentorDashboard

https://gerrit.wikimedia.org/r/715610

gerritbot added a comment.Aug 30 2021, 11:05 PM

Change 715610 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.20] Instrument Special:MentorDashboard

https://gerrit.wikimedia.org/r/715610

Stashbot added a comment.Aug 30 2021, 11:08 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-30T23:08:05Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php: 9e2264a0c9a48548da4795b2a5b9d7275d254ac7: Instrument Special:MentorDashboard (T289369) (duration: 00m 57s)

Stashbot added a comment.Aug 30 2021, 11:11 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-30T23:11:04Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/GrowthExperiments/includes/Specials/SpecialMentorDashboard.php: 9e2264a0c9a48548da4795b2a5b9d7275d254ac7: Instrument Special:MentorDashboard (T289369) (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.20; 2021-08-23); removed MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 31 2021, 12:00 AM
Urbanecm_WMF closed this task as Resolved.Aug 31 2021, 12:52 AM
Urbanecm_WMF moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

I backported the instrumentation to production to be able to double check it at testwiki. Then I opened the dashboard at testwiki, and this is what was sent:

{
  "meta": {
    "domain": "test.wikipedia.org",
    "stream": "mediawiki.mentor_dashboard.visit",
    "id": "b2ea8441-0bc5-4bc0-b5d0-e0e9566462d6",
    "dt": "2021-08-30T23:16:33.303Z",
    "request_id": "df77f986-c863-4684-9184-061a75598aae",
    "topic": "codfw.mediawiki.mentor_dashboard.visit",
    "partition": 0,
    "offset": 18
  },
  "http": {
    "request_headers": {
      "user-agent": "<redacted>"
    }
  },
  "$schema": "/analytics/mediawiki/mentor_dashboard/visit/1.0.0",
  "user_id": 43912,
  "is_mobile": false,
  "dt": "2021-08-30T23:16:33Z"
}

After a while, the event got ingested into Hadoop as well. Looks it all works as expected :).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL