Page MenuHomePhabricator
Create Task
Maniphest T289384

SpecialGlobalWatchlistSettings site validation fails on Vagrant
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

SpecialGlobalWatchlistSettings uses WikiReference::getDisplayName() to generate urls that should be supported based on attached CentralAuth accounts. However, vagrant wikis have a port in the url that is not included in the display name, which means that the correct url is considered invalid. We should fix that

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SpecialGlobalWatchlistSettings: accept sites with a portmediawiki/extensions/GlobalWatchlistmaster+20 -2
Customize query in gerrit

Event Timeline

DannyS712 created this task.Aug 20 2021, 10:00 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 20 2021, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 20 2021, 10:12 PM

Change 713865 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] SpecialGlobalWatchlistSettings: accept sites with a port

https://gerrit.wikimedia.org/r/713865

gerritbot added a project: Patch-For-Review.Aug 20 2021, 10:12 PM
DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.Aug 20 2021, 11:00 PM
gerritbot added a comment.Aug 22 2021, 5:57 PM

Change 713865 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] SpecialGlobalWatchlistSettings: accept sites with a port

https://gerrit.wikimedia.org/r/713865

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 22 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 22 2021, 6:10 PM
DannyS712 closed this task as Resolved.Aug 24 2021, 11:27 PM
DannyS712 claimed this task.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 1.
DannyS712 set Final Story Points to 2.

Tested locally with Vagrant, confirmed to work now

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits