Page MenuHomePhabricator

SpecialGlobalWatchlistSettings site validation fails on Vagrant
Closed, ResolvedPublic1 Estimated Story Points

Description

SpecialGlobalWatchlistSettings uses WikiReference::getDisplayName() to generate urls that should be supported based on attached CentralAuth accounts. However, vagrant wikis have a port in the url that is not included in the display name, which means that the correct url is considered invalid. We should fix that

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 713865 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] SpecialGlobalWatchlistSettings: accept sites with a port

https://gerrit.wikimedia.org/r/713865

Change 713865 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] SpecialGlobalWatchlistSettings: accept sites with a port

https://gerrit.wikimedia.org/r/713865

DannyS712 claimed this task.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set the point value for this task to 1.
DannyS712 set Final Story Points to 2.

Tested locally with Vagrant, confirmed to work now