Page MenuHomePhabricator

Increase deployment target to iOS 13.0
Closed, ResolvedPublic

Description

Increase project deployment target to iOS 13.0, fix warnings.

QA Notes

First do a basic test is to confirm that the app can no longer be installed on iOS12.

We also had to add various code changes to address Xcode warnings. Here are areas that might have regressions from that:

  • Loading spinner theming (Peek & pop views, article gallery, link editor, image editor, article history counts, article languages)
  • Layout on onboarding/welcome screens (iPhone vs iPad)
  • Status bar hiding
  • Scroll indicator locations on list screens and article table of contents
  • Article table of contents presentation
  • Colors on popup banners (errors, no connection, etc.)
  • Background app refreshing (not really sure how QA can test this, just listing for completion's sake)
  • Points of interest are still hidden on map in Places
  • Previous search terms on Places, confirm you can still swipe to delete and that deleting works.

Peek & Pop - this has been enabled again as a long press with contextual menus throughout the app. Please test long press / preview / and choosing menu options from:

  • Explore tab cells and attached list screens (on this day, top read, in the news, etc.).
  • Places tab - list of places
  • Saved tab - article cells
  • History tab - article cells
  • Search results - article cells
  • Editing flow - insert link wizard search results and insert image wizard search results
  • Article view - links

Event Timeline

LGoto triaged this task as High priority.Aug 30 2021, 6:42 PM
LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

https://github.com/wikimedia/wikipedia-ios/pull/4029 (Part 1 of 2)

Note for QA - here are areas that might have regressions:

  • Loading spinner theming (Peek & pop views, article gallery, link editor, image editor, article history counts, article languages)
  • Layout on onboarding/welcome screens (iPhone vs iPad)
  • Status bar hiding
  • Scroll indicator locations on list screens and article table of contents
  • Article table of contents presentation
  • Colors on popup banners (errors, no connection, etc.)
  • Background app refreshing (not really sure how QA can test this, just listing for completion's sake)
  • Points of interest are still hidden on map in Places
  • Previous search terms on Places, confirm you can still swipe to delete and that deleting works.

Switching briefly to do notifications work on https://phabricator.wikimedia.org/T287298, will pick this back up after I make another PR there.

Part 2 progress branch is in T289535-2. I have removed all the warnings and reworked peek and pop to use the UIContextMenuConfiguration previewing. Remaining work is:

  1. Add UIContextMenuActionProvider for all new UIContextMenuConfigurations I have made so far for any new areas previewing to articles, so we see "Read now", "Save for later", etc context menu options when peeking in these new spots. Can probably lean on previewActions property in ArticleViewControllerLinkPreviewing.swift, though we should also probably rework that property since UIPreviewAction is deprecated.
  2. UI polish - I sometimes see flashes of the wrong background color depending on the theme when peeking.
  3. Performance optimization - generally peeking felt slower elsewhere in the app than on the article, so maybe we can look into adding any pre-fetching like we do in the contextMenuConfigurationForLinkURL of ArticleContextMenuPresenting.swift).
  4. Altogether this branch probably could use some code cleanup and maybe protocol extensions or the like to make this new stuff more DRY.

This will be available to test starting in the next TestFlight build (6.9.0 1884).

@ABorbaWMF given the difficulty in finding test devices we're going to take similator testing as sufficient, so you're off the hook for this one. Ideally we'd have you get a device eventually but I don't think the risk here is worth blocking you on it.

JMinor claimed this task.