Page MenuHomePhabricator
Create Task
Maniphest T289570

Special:ContentTranslation: The use of the `legacy` feature with ResourceLoaderSkinModule is deprecated
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

This page is using the deprecated ResourceLoader module "mw.cx.skin".
[1.37] The use of the `legacy` feature with ResourceLoaderSkinModule is deprecated(T89981). More information can be found at [[mw:Manual:ResourceLoaderSkinModule]].

See T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature

What should have happened instead?:
No deprecation warning

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CX Skin: Inlclude link related styles and overridesmediawiki/extensions/ContentTranslationmaster+19 -0
CX Skin: Fix deprecation warning about legacy feature of ResourceLoaderSkinModulemediawiki/extensions/ContentTranslationmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Aug 24 2021, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2021, 12:44 PM
santhosh claimed this task.Sep 8 2021, 8:46 AM
gerritbot added a comment.Sep 8 2021, 8:50 AM

Change 719469 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX Skin: Fix deprecation warning about legacy feature of ResourceLoaderSkinModule

https://gerrit.wikimedia.org/r/719469

gerritbot added a project: Patch-For-Review.Sep 8 2021, 8:50 AM
santhosh triaged this task as Low priority.Sep 8 2021, 8:52 AM
santhosh added a project: Language-Team (Language-2021-July-September).
santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.
gerritbot added a comment.Sep 8 2021, 9:54 AM

Change 719469 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Skin: Fix deprecation warning about legacy feature of ResourceLoaderSkinModule

https://gerrit.wikimedia.org/r/719469

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 8 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 8 2021, 10:10 AM
santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2021-July-September) board.Sep 9 2021, 4:32 AM
• Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2021-July-September) board.Sep 12 2021, 8:48 PM
• Jpita added subscribers: Pginer-WMF, • Jpita.Sep 12 2021, 8:53 PM

@santhosh @Pginer-WMF should we create the same task for SX?

santhosh added a comment.Sep 14 2021, 10:30 AM
In T289570#7347091, @Jpita wrote:

@santhosh @Pginer-WMF should we create the same task for SX?

This fixes it for SX too. SX uses Special:ContentTranslation and same skin. https://sx.wmflabs.org/index.php/Special:ContentTranslation should not show the warning

• Jpita added a comment.Sep 14 2021, 1:31 PM
In T289570#7351470, @santhosh wrote:
In T289570#7347091, @Jpita wrote:

@santhosh @Pginer-WMF should we create the same task for SX?

This fixes it for SX too. SX uses Special:ContentTranslation and same skin. https://sx.wmflabs.org/index.php/Special:ContentTranslation should not show the warning

it seems to be a different one.
is there a ticket for this one @Pginer-WMF ?

image.png (76×1 px, 27 KB)

santhosh added a comment.Sep 15 2021, 4:42 AM

jquery.throttle-debounce is not used in CX, but there are extensions that use it. Hopefully those extension maintainers will fix it.

santhosh mentioned this in T291252: Regression in link styles on Content Translation.Sep 20 2021, 4:56 AM
gerritbot added a comment.Sep 20 2021, 4:59 AM

Change 722130 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX Skin: Inlclude link related styles and overrides

https://gerrit.wikimedia.org/r/722130

gerritbot added a project: Patch-For-Review.Sep 20 2021, 4:59 AM
gerritbot added a comment.Sep 20 2021, 7:56 AM

Change 722130 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Skin: Inlclude link related styles and overrides

https://gerrit.wikimedia.org/r/722130

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2021, 8:10 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:31 PM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-October-December) board.
• Jpita moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-October-December) board.Oct 4 2021, 12:01 PM
Pginer-WMF closed this task as Resolved.Oct 7 2021, 10:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits