Page MenuHomePhabricator

Claim mentee: Send a notification to former mentor
Closed, ResolvedPublic

Description

Problem

When a mentor uses Special:ClaimMentee to claim a mentee, the mentee will receive a notification about the change. The user's past mentor, however, isn't informed about that change. If someone misuses the claim mentee feature, it might go easily unnoticed. Especially since the claim mentee feature will become more advertised through GrowthExperiments-MentorDashboard, something should be done to make abuse noticeable.

Solution

If the claim mentee feature changes a mentor, inform the previous mentor about the change via a notification. The notification should be opt-out for the mentor.

The code should make to easy to suppres the notification for a given mentor change. This is important to support T280307: Mentor dashboard: M2 mentor tools/settings, which will basically do a batch of mentor changes if a mentor decides to quit mentoring.

Event Timeline

@RHo @MMiller_WMF This is basically ready for development, except that I'm not sure what the wording should be. Would something like "One of your mentees, <mentee>, was claimed by <mentor>" be okay? Also, is it okay if it is in the "low priority" notifications (not in the bell, but together with thanks, etc.)?

@RHo @MMiller_WMF This is basically ready for development, except that I'm not sure what the wording should be. Would something like "One of your mentees, <mentee>, was claimed by <mentor>" be okay? Also, is it okay if it is in the "low priority" notifications (not in the bell, but together with thanks, etc.)?

Hi @Urbanecm_WMF - that wording SGTM to me. And I agree this would be a low priority notice, not an alert (bell) type notification.

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>." Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

Also, is there some way to include a link in the notification for the mentor to find out what "claiming" means if they don't know? We could link to the help page on mediawiki.org: https://www.mediawiki.org/wiki/Help:Growth/Tools/How_to_claim_a_mentee

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>." Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

I agree they should match, but also that they should both be notices, since these are notifications deemed not urgent and not actionable per https://www.mediawiki.org/wiki/Notifications/Sorting_schemes

Also, is there some way to include a link in the notification for the mentor to find out what "claiming" means if they don't know? We could link to the help page on mediawiki.org: https://www.mediawiki.org/wiki/Help:Growth/Tools/How_to_claim_a_mentee

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>."

Thanks, looks good to me.

Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

Being claimed is a bell notification. I think the difference kinda makes sense, as mentors will likely get more notifications than the mentees (a mentee is unlikely to be claimed multiple times). Changing the type of the notification is easy (in any direction).

Also, is there some way to include a link in the notification for the mentor to find out what "claiming" means if they don't know? We could link to the help page on mediawiki.org: https://www.mediawiki.org/wiki/Help:Growth/Tools/How_to_claim_a_mentee

Yes, that is possible. Notifications have one primary link, and any number of secondary links. I'd use the mentee's user page for the primary link, and we can link the documentation using a secondary link. It would look like this:

image.png (168×671 px, 20 KB)

The "View changes" is a secondary link.

Would that work for you?

Change 730698 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Move BeforeCreateEchoEvent hook handler to MentorHooks

https://gerrit.wikimedia.org/r/730698

Change 730699 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Claim mentee: Send a notification to former mentor

https://gerrit.wikimedia.org/r/730699

Change 730705 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Claim mentee: Rename Echo icon to growthexperiments-mentor

https://gerrit.wikimedia.org/r/730705

Moving to in progress, as I started engineering this functionality, as I have enough information to work on this now (thanks for the fast response!). I'm going to first create this as a notice; if we decide to change that (either make this notification as alert, or the "you were claimed" one as a notice), it should be easy to do.

Change 730698 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Move BeforeCreateEchoEvent hook handler to MentorHooks

https://gerrit.wikimedia.org/r/730698

Change 730705 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Claim mentee: Rename Echo icon to growthexperiments-mentor

https://gerrit.wikimedia.org/r/730705

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>."

Thanks, looks good to me.

Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

Being claimed is a bell notification. I think the difference kinda makes sense, as mentors will likely get more notifications than the mentees (a mentee is unlikely to be claimed multiple times). Changing the type of the notification is easy (in any direction).

Okay, I agree with you, @Urbanecm_WMF. Let's make the notification for the mentee to be a bell and for the mentor to be a tray. I think we do want the mentee to take action when their mentor changes, like asking them a question or saying hello.

Also, is there some way to include a link in the notification for the mentor to find out what "claiming" means if they don't know? We could link to the help page on mediawiki.org: https://www.mediawiki.org/wiki/Help:Growth/Tools/How_to_claim_a_mentee

Yes, that is possible. Notifications have one primary link, and any number of secondary links. I'd use the mentee's user page for the primary link, and we can link the documentation using a secondary link. It would look like this:

image.png (168×671 px, 20 KB)

The "View changes" is a secondary link.

Would that work for you?

Yes, that would work. The secondary link could be labeled, "About claiming"

I'm also wondering whether these notifications need to have a row in this table on https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo. Do you know if it's standard practice for all notification types to be in the list?

image.png (1×806 px, 112 KB)

@Urbanecm_WMF -- here's my edit to the wording: "Your mentee, <mentee>, was claimed by <mentor>."

Thanks, looks good to me.

Is the notification for being claimed also a low-priority one? Or is it a bell? I think they should match.

Being claimed is a bell notification. I think the difference kinda makes sense, as mentors will likely get more notifications than the mentees (a mentee is unlikely to be claimed multiple times). Changing the type of the notification is easy (in any direction).

Okay, I agree with you, @Urbanecm_WMF. Let's make the notification for the mentee to be a bell and for the mentor to be a tray. I think we do want the mentee to take action when their mentor changes, like asking them a question or saying hello.

Ack, thanks!

Also, is there some way to include a link in the notification for the mentor to find out what "claiming" means if they don't know? We could link to the help page on mediawiki.org: https://www.mediawiki.org/wiki/Help:Growth/Tools/How_to_claim_a_mentee

Yes, that is possible. Notifications have one primary link, and any number of secondary links. I'd use the mentee's user page for the primary link, and we can link the documentation using a secondary link. It would look like this:

image.png (168×671 px, 20 KB)

The "View changes" is a secondary link.

Would that work for you?

Yes, that would work. The secondary link could be labeled, "About claiming"

Thanks, sounds good to me.

I'm also wondering whether these notifications need to have a row in this table on https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo. Do you know if it's standard practice for all notification types to be in the list?

image.png (1×806 px, 112 KB)

Almost all notifications should have a matching row there. The only exemption are "system" notifications, which are notifications that need to show up always, for some reason. They have to be extremely low frequency. The "You were claimed" notification meets that, and when creating the feature, it was added as a system notification. It happens only one or two times for user, so it's not a big deal to (ab)use the system notifications concept.

For notifications directed to mentors, I'm personally for creating a new category for them. We could use one of the already existing categories in theory, but I don't see one that would be appropriate for that purpose.

Currently, I plan to call the new category "Mentorship", and put "Notifications related to mentorship features maintained by the Growth team. This notification lets you know that you were claimed as a mentee, or that one of your mentees was claimed by someone else." into the info icon -- of course, wording can be changed as you wish!

@Urbanecm_WMF -- would this new "Mentorship" notification preference be visible for all users, or only those with the homepage or who are mentors? And would we be able to set defaults (i.e. defaulting it to "on")?

@Urbanecm_WMF -- would this new "Mentorship" notification preference be visible for all users, or only those with the homepage or who are mentors? And would we be able to set defaults (i.e. defaulting it to "on")?

I plan to show it to all users, enabled by default (web only). Do you think it needs to be hidden for non-mentors?

We can set the defaults to whatever we want, no problem. Just let me know how you want the boxes to be checked by default :).

Change 730699 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Claim mentee: Send a notification to former mentor

https://gerrit.wikimedia.org/r/730699

Change 734892 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Include link to \"What is claim mentee\" in notification for former mentors

https://gerrit.wikimedia.org/r/734892

image.png (481×1 px, 131 KB)

This is how the feature currently looks like. The notification as a whole links to the mentee's userpage, the secondary link (labeled "What is "Claim a mentee"?") leads to https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Growth/Tools/How_to_claim_a_mentee.

Let me know if you want me to make any changes in the copies.

Change 734892 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Include link to \"What is claim mentee\" in notification for former mentors

https://gerrit.wikimedia.org/r/734892

This should now be done. Will be released with the next train.

Etonkovidova subscribed.

@MMiller_WMF, @RHo - FYI

Checked on betalabs - seems that everything is in place:

  • For a mentor the notification is a notice; for a mentee - an alert.
notification to a mentornotification to a mentee
Screen Shot 2021-11-03 at 5.37.20 PM.png (662×1 px, 86 KB)
Screen Shot 2021-11-03 at 5.37.43 PM.png (204×584 px, 27 KB)

Screen Shot 2021-11-03 at 5.43.29 PM.png (828×470 px, 74 KB)

Checked on testwiki wmf.9 - all works as expected; closing as Resolved