Page MenuHomePhabricator

Language icon increases in size when TypeaheadSearch input is focussed/language switcher is clicked
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The ULS language switcher icon increases in size

InititalFocussed
image.png (112×2 px, 18 KB)
image.png (114×2 px, 21 KB)

What should have happened instead?:
The icons size should stay the same.

Event Timeline

The language icon is provided by ULS not Vector. It looks like the ULS icon uses background-size: contain; rather than background-size: 20px; so will grow with any changes to the surrounding elements in a flex box layout.

@Jdlrobson @ovasileva should this be a general task about fixing the ULS button in the site header? It currently doesn't match the other buttons: font-weight is off, icon sizing, no hover state

Screen Shot 2021-08-25 at 11.36.40 AM.png (75×802 px, 7 KB)

ovasileva triaged this task as Medium priority.Aug 25 2021, 5:44 PM
ovasileva added a project: Readers-Web-Backlog.

Probably, but who's going to do this? The language team or the web team? The web team still has little experience and confidence in touching that extension without hand-holding from the language team.

@Nikerabbit, @Pginer-WMF - seems like we have another request for you all. Do you think you might have some capacity to help us with this task? From our side, current priority has increased somewhat since we are planning on adding mediawiki to our list of pilot wikis

@Nikerabbit, @Pginer-WMF - seems like we have another request for you all. Do you think you might have some capacity to help us with this task? From our side, current priority has increased somewhat since we are planning on adding mediawiki to our list of pilot wikis

Sure. I added it to our sprint board. A first glance does not seem a complex change, but I'll check with the engineers on the team.

Change 715268 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Language button icon/button should be consistent with other buttons

https://gerrit.wikimedia.org/r/715268

Change 715759 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Skin style for ULS no longer needed

https://gerrit.wikimedia.org/r/715759

Change 715760 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Pull out Vector personal tools styles into skinStyle

https://gerrit.wikimedia.org/r/715760

I submitted a change and Santhosh has reviewed. Adding to board for visibility.

Change 715268 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Language button icon/button should be consistent with other buttons

https://gerrit.wikimedia.org/r/715268

I QAd the merged patch on translatewiki.net. Assuming this is not a transitional issue until other patches are merged, I'm posting the results:

On all skins (Timeless, Vector, Monobook), the icon gets duplicated after the personal toolbar language element is activated. Example in Vector:

kuva.png (156×1 px, 12 KB)

On Timeless and Vector (but not Monobook), the text is now bold black instead of blue. Not sure if this is expected, but it looks inconsistent.

On all skins the element now lacks all focus indicator (keyboard focus and active element focus), which it used to have.

Change 715992 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Register meta data to allow Vector to handle display of this menu item

https://gerrit.wikimedia.org/r/715992

Change 715084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Separate icon classes from button classes in user links/language

https://gerrit.wikimedia.org/r/715084

Change 715084 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Separate icon classes from button classes in user links/language

https://gerrit.wikimedia.org/r/715084

Change 715084 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Simplify how we generate icons and button classes in Vector

https://gerrit.wikimedia.org/r/715084

Change 715992 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Register meta data to allow Vector to handle display of this menu item

https://gerrit.wikimedia.org/r/715992

Change 715759 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Skin style for ULS no longer needed

https://gerrit.wikimedia.org/r/715759

Change 715760 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Pull out Vector personal tools styles into skinStyle

https://gerrit.wikimedia.org/r/715760

checked on Office WIki and language button looks great! and the size increase issue is no longer occurring

Resolving, looks good!