Page MenuHomePhabricator

502 when trying to edit a patch thru web uploaded with Gerrit Patch Uploader
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Upload a file with Gerrit Patch Uploader
  • using the Gerrit Web interface, attempt to edit the uploaded file OR attempt to upload a second file to the same subject

What happens?:
Edit or upload fails with message:

An error occurred
Error 502 (Bad Gateway): <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Bad Gateway</title>
</head><body>
<h1>Bad Gateway</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
</p>
</body></html>

Endpoint: /changes/*~*/edit/*

What should have happened instead?:
The edit or upload should have completed successfully

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Patch in question here, related to T151682
I was unable to upload languages/i18n/en.json nor languages/i18n/qqq.json, attempted changes described in T151682#7303345. I also tried to edit the uploaded file to replace:

!$this->getTitle()->isSpecialPage()

with

$this->getTitle()->canExist()

The change would ensure the new message would not show on nonexistent pages. The edit failed with the same 502 error.
Discussion also started here

Event Timeline

Ivi104 updated the task description. (Show Details)

You have to be in the Trusted-Contributors group on Gerrit to amend other users' changes, so the error is probably due to the fact that 'Gerrit Patch Uploader' is the owner, though the error should then be 403 instead of 502.

hashar updated the task description. (Show Details)
hashar subscribed.

Retagged for Tool-Gerrit-Patch-Uploader , looks like the tool should catch the user lacks the permission to upload a patch.