Page MenuHomePhabricator
Create Task
Maniphest T289654

Netlify deploy URLs posted to PRs as a comment are broken
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Netlify deploy URLs posted to PRs as a comment have been broken since at least the 20th of August 2021.

Current Behaviour:

The links in all PRs - since at least the 20th of August 2021, have been leading to a page displaying the following message or similar:

Not found - Request ID: 01FDY5H46V55AWW7RD0GK5ZH0Q

Expected behaviour:

Netlify links posted on each PR as a comment lead to the composed Storybook for that PR.

Note: The GitHub action that builds the link for the Saucelabs browser tests is not doing the same thing as the GitHub action that comments the deploy URL to the PR. Maybe something in Netlify's logic changed and since we don't use the official "Preview" we are experiencing this problem.

Acceptance Criteria: 🏕️🌟 (August 2021)

  • Netlify links posted on each PR as a comment lead to the composed Storybook for that PR.

Repo: https://github.com/wmde/wikit

Event Timeline

ItamarWMDE created this task.Aug 25 2021, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2021, 8:08 AM
• Tonina_Zhelyazkova_WMDE moved this task from Incoming to Tech on the Wikidata Design System board.Aug 25 2021, 8:17 AM
• Tonina_Zhelyazkova_WMDE renamed this task from Netlify links seems to be broken to Netlify deploy URLs posted to PRs as a comment are broken.Aug 26 2021, 4:50 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)
• Tonina_Zhelyazkova_WMDE added a project: [DEPRECATED] wdwb-tech.
Michael subscribed.Aug 30 2021, 8:00 AM
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Aug 30 2021, 3:29 PM
Addshore moved this task from To Prioritize to Triaged High (100+) on the [DEPRECATED] wdwb-tech board.Aug 31 2021, 11:21 AM
Addshore added a project: Wikidata-Campsite.Aug 31 2021, 11:28 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore triaged this task as Medium priority.Aug 31 2021, 2:23 PM
Addshore updated the task description. (Show Details)
Addshore updated the task description. (Show Details)Sep 1 2021, 10:38 AM
Michael added a comment.Sep 1 2021, 10:39 AM

I stumbled over it earlier, but got distracted again by other issues before I was able to do anything useful about it.

Addshore set the point value for this task to 3.Sep 1 2021, 10:40 AM
Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Sep 1 2021, 10:43 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from Triaged High (100+) to Active on the [DEPRECATED] wdwb-tech board.
Ladsgroup claimed this task.Sep 7 2021, 9:05 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup subscribed.

https://github.com/wmde/wikit/pull/476

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptSep 7 2021, 9:05 PM
• Tonina_Zhelyazkova_WMDE moved this task from Tech to Ongoing on the Wikidata Design System board.Sep 8 2021, 8:41 AM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 8 2021, 9:48 AM
Addshore closed this task as Resolved.Sep 15 2021, 2:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits