Page MenuHomePhabricator
Create Task
Maniphest T289661

Refactor puppet:base module to reduce unneeded shared code paths
Closed, ResolvedPublic
Actions

Description

We currently have a few modules shared between cloud services VPS environment and the production environment which don't necessarily need to be shared. the biggest example of this is profile::base. We should split this profile up so that we have a separate profile::base::production ensuring all production specific code is only added there. Further we should make better use of heira. many classes and profiles have a large if/else block based on the realm variable however in most cases we should be able to refactor the code to control difference between the cloud and production environments by passing different hiera values.

Details

Other Assignee
jbond
Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

jbond created this task.Aug 25 2021, 8:54 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptAug 25 2021, 8:54 AM
jbond triaged this task as Medium priority.Aug 25 2021, 9:15 AM
jbond added a subscriber: dcaro.
jbond mentioned this in T289666: Improve PCC support for cloud VPS environments.Aug 25 2021, 9:26 AM
dcaro claimed this task.Aug 26 2021, 8:14 AM
dcaro updated the task description. (Show Details)Aug 26 2021, 8:20 AM
gerritbot added a comment.Aug 26 2021, 10:28 AM

Change 714980 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] debdeploy: move debdeploy to its own class

https://gerrit.wikimedia.org/r/714980

gerritbot added a project: Patch-For-Review.Aug 26 2021, 10:28 AM
gerritbot added a comment.Aug 26 2021, 11:04 AM

Change 714980 merged by Jbond:

[operations/puppet@production] debdeploy: move debdeploy to its own class

https://gerrit.wikimedia.org/r/714980

gerritbot added a comment.Aug 26 2021, 11:26 AM

Change 714991 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:debdeploy::client: Add debdeploy profile

https://gerrit.wikimedia.org/r/714991

gerritbot added a comment.Aug 26 2021, 11:36 AM

Change 714991 merged by Jbond:

[operations/puppet@production] P:debdeploy::client: Add debdeploy profile

https://gerrit.wikimedia.org/r/714991

gerritbot added a comment.Aug 26 2021, 12:14 PM

Change 715003 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:standard: move admin to its own profile

https://gerrit.wikimedia.org/r/715003

gerritbot added a comment.Aug 26 2021, 12:32 PM

Change 714975 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base: move production specific code to there own profile

https://gerrit.wikimedia.org/r/714975

gerritbot added a comment.Aug 26 2021, 12:53 PM

Change 715010 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base: Create profile::apt

https://gerrit.wikimedia.org/r/715010

gerritbot added a comment.Aug 26 2021, 2:21 PM

Change 715010 merged by Jbond:

[operations/puppet@production] P:base: Create profile::apt

https://gerrit.wikimedia.org/r/715010

gerritbot added a comment.Sep 2 2021, 2:14 PM

Change 715003 merged by David Caro:

[operations/puppet@production] P:standard: move admin to its own profile

https://gerrit.wikimedia.org/r/715003

gerritbot added a comment.Sep 3 2021, 10:24 AM

Change 717241 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] base::resolving: convert base::resolving to a profile

https://gerrit.wikimedia.org/r/717241

taavi removed a project: Cloud Services Proposals.Sep 19 2021, 3:23 PM
gerritbot added a comment.Sep 23 2021, 1:23 PM

Change 717241 merged by Jbond:

[operations/puppet@production] base::resolving: convert base::resolving to a profile

https://gerrit.wikimedia.org/r/717241

gerritbot added a comment.Sep 24 2021, 11:56 AM

Change 723509 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base: make notifications_enabled a boolean

https://gerrit.wikimedia.org/r/723509

dcaro edited projects, added cloud-services-team (zz-archived1); removed cloud-services-team (Kanban).Sep 28 2021, 4:30 PM
dcaro moved this task from Backlog to Today on the cloud-services-team (zz-archived1) board.Sep 30 2021, 7:55 AM
gerritbot added a comment.Sep 30 2021, 9:05 AM

Change 723509 merged by David Caro:

[operations/puppet@production] P:base: make notifications_enabled a boolean

https://gerrit.wikimedia.org/r/723509

dcaro moved this task from Today to Backlog on the cloud-services-team (zz-archived1) board.Sep 30 2021, 1:49 PM
gerritbot added a comment.Oct 1 2021, 12:50 PM

Change 725311 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:rsyslog::kafka_shipper: set hiera config directly in this profile

https://gerrit.wikimedia.org/r/725311

gerritbot added a comment.Oct 1 2021, 1:00 PM

Change 725311 merged by Jbond:

[operations/puppet@production] P:rsyslog::kafka_shipper: set hiera config directly in this profile

https://gerrit.wikimedia.org/r/725311

gerritbot added a comment.Oct 1 2021, 1:36 PM

Change 725317 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] debdeploy: move base::autorestart into debdeploy module

https://gerrit.wikimedia.org/r/725317

MoritzMuehlenhoff subscribed.Oct 1 2021, 8:50 PM
dcaro edited projects, added cloud-services-team (Kanban), User-dcaro; removed cloud-services-team (zz-archived1).Oct 5 2021, 9:03 AM
jbond renamed this task from Audit usages or the realm variable with a view to drop it to Refactor puppet:base module to reducs unneeded shared code paths.Oct 5 2021, 10:27 AM
jbond updated the task description. (Show Details)
jbond updated the task description. (Show Details)
jbond edited subscribers, added: • joanna_borun; removed: MoritzMuehlenhoff, taavi, Aklapper and 6 others.
MoritzMuehlenhoff subscribed.Oct 5 2021, 10:34 AM
Aklapper subscribed.Oct 5 2021, 12:45 PM
gerritbot added a comment.Oct 7 2021, 10:36 AM

Change 727235 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] base::auto_restarts: move to profile and make debdeploy support optional

https://gerrit.wikimedia.org/r/727235

gerritbot added a comment.Oct 7 2021, 10:37 AM

Change 725317 abandoned by Jbond:

[operations/puppet@production] debdeploy: move base::autorestart into debdeploy module

Reason:

superseded by https://gerrit.wikimedia.org/r/c/operations/puppet/+/727235

https://gerrit.wikimedia.org/r/725317

gerritbot added a comment.Oct 7 2021, 10:45 AM

Change 727242 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P::base: create standard directories in base::standard_packages

https://gerrit.wikimedia.org/r/727242

gerritbot added a comment.Oct 7 2021, 11:55 AM

Change 727242 merged by Jbond:

[operations/puppet@production] P::base: create standard directories in base::standard_packages

https://gerrit.wikimedia.org/r/727242

gerritbot added a comment.Oct 7 2021, 4:35 PM

Change 727235 merged by Jbond:

[operations/puppet@production] base::auto_restarts: move to profile and make debdeploy support optional

https://gerrit.wikimedia.org/r/727235

dcaro moved this task from To refine to Today on the User-dcaro board.Oct 15 2021, 7:55 AM
gerritbot added a comment.Oct 15 2021, 10:42 AM

Change 731012 had a related patch set uploaded (by David Caro; author: David Caro):

[operations/puppet@production] p:environment: Move wmcs specific etc files to p:wmcs::instance

https://gerrit.wikimedia.org/r/731012

gerritbot added a comment.Oct 15 2021, 1:25 PM

Change 731012 merged by David Caro:

[operations/puppet@production] p:environment: Move wmcs specific etc files to p:wmcs::instance

https://gerrit.wikimedia.org/r/731012

dcaro moved this task from Today to To refine on the User-dcaro board.Oct 15 2021, 1:27 PM
dcaro renamed this task from Refactor puppet:base module to reducs unneeded shared code paths to Refactor puppet:base module to reduce unneeded shared code paths.Oct 15 2021, 1:58 PM
gerritbot added a comment.Oct 21 2021, 10:19 AM

Change 714975 merged by Jbond:

[operations/puppet@production] P:base: move production specific code to their own profile

https://gerrit.wikimedia.org/r/714975

gerritbot added a comment.Oct 21 2021, 10:43 AM

Change 732638 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base::production: update production roles to use P::base::production

https://gerrit.wikimedia.org/r/732638

gerritbot added a comment.Oct 21 2021, 10:43 AM

Change 732639 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base::labs: update labs base profile to include profile::base

https://gerrit.wikimedia.org/r/732639

gerritbot added a comment.Oct 21 2021, 11:39 AM

Change 732670 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:base::production: add parameters to disable this profile

https://gerrit.wikimedia.org/r/732670

gerritbot added a comment.Oct 21 2021, 12:30 PM

Change 732670 merged by Jbond:

[operations/puppet@production] P:base::production: add parameters to disable this profile

https://gerrit.wikimedia.org/r/732670

gerritbot added a comment.Oct 21 2021, 12:30 PM

Change 732638 merged by Jbond:

[operations/puppet@production] P:base::production: update production roles to use P::base::production

https://gerrit.wikimedia.org/r/732638

gerritbot added a comment.Oct 21 2021, 12:30 PM

Change 732639 merged by Jbond:

[operations/puppet@production] P:base::labs: update labs base profile to include profile::base

https://gerrit.wikimedia.org/r/732639

dcaro moved this task from To refine to Today on the User-dcaro board.Oct 28 2021, 8:19 AM
dcaro moved this task from Today to To refine on the User-dcaro board.Oct 29 2021, 7:52 AM
gerritbot added a comment.Nov 5 2021, 11:11 AM

Change 737005 had a related patch set uploaded (by Vgutierrez; author: Vgutierrez):

[operations/puppet@production] upload_haproxy: Adopt ::profile::base::production

https://gerrit.wikimedia.org/r/737005

gerritbot added a comment.Nov 5 2021, 11:17 AM

Change 737005 merged by Vgutierrez:

[operations/puppet@production] upload_haproxy: Adopt ::profile::base::production

https://gerrit.wikimedia.org/r/737005

dcaro added a project: Cloud-Services-Worktype-Maintenance.Nov 24 2021, 2:31 PM
dcaro added a project: Cloud-Services-Origin-Team.
jbond closed this task as Resolved.Dec 9 2021, 4:27 PM
jbond updated Other Assignee, added: jbond.

this is complete

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits