Page MenuHomePhabricator

Add more rspec test to the puppet code
Open, MediumPublic

Description

We should try and get to a point where all modules have at the very least a basic rspec stanza like the following

require_relative '../../../../rake_modules/spec_helper'

describe 'netbase' do
  on_supported_os(WMFConfig.test_on).each do |os, facts|
    context "on #{os}" do
      let(:facts) { facts }
      describe 'test with default settings' do
        it { is_expected.to compile.with_all_deps }
      end
    end
  end
end

This would ensure we catch very simple issues and also ensure that we have some scaffolding allready in plce if useres want to add more test cases