Page MenuHomePhabricator
Create Task
Maniphest T289726

Indicate on label search results if they are aliases, and show their primary label
Closed, ResolvedPublic
Actions

Description

e.g. Wikidata shows search results as Foo (Bar) when the user searches for 'Bar' and gets the result of 'Foo'; something similar might make sense for us, at least at first?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Properly find the selected ZObject when an alias record is selectedmediawiki/extensions/WikiLambdamaster+14 -1
Display labels on alias searches in the ZObjectSelectormediawiki/extensions/WikiLambdamaster+18 -2
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Aug 25 2021, 7:18 PM
Lindsaykwardell claimed this task.Aug 26 2021, 4:01 PM
gerritbot added a comment.Aug 26 2021, 4:02 PM

Change 715052 had a related patch set uploaded (by Lindsay Wardell; author: Lindsay Wardell):

[mediawiki/extensions/WikiLambda@master] Display labels on alias searches in the ZObjectSelector

https://gerrit.wikimedia.org/r/715052

gerritbot added a project: Patch-For-Review.Aug 26 2021, 4:02 PM
gerritbot added a comment.Aug 26 2021, 5:04 PM

Change 715052 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Display labels on alias searches in the ZObjectSelector

https://gerrit.wikimedia.org/r/715052

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 5:10 PM
Jdforrester-WMF added a comment.Aug 26 2021, 11:02 PM

Do we want to do more on this to cope with when labels / aliases have ()s in them?

Lindsaykwardell added a comment.Aug 27 2021, 1:42 PM

I think so, yes.

gerritbot added a comment.Aug 30 2021, 9:39 PM

Change 715605 had a related patch set uploaded (by Lindsay Wardell; author: Lindsay Wardell):

[mediawiki/extensions/WikiLambda@master] Properly find the selected ZObject when an alias record is selected

https://gerrit.wikimedia.org/r/715605

gerritbot added a project: Patch-For-Review.Aug 30 2021, 9:39 PM
gerritbot added a comment.Aug 31 2021, 5:13 PM

Change 715605 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Properly find the selected ZObject when an alias record is selected

https://gerrit.wikimedia.org/r/715605

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2021, 6:10 PM
Jdforrester-WMF closed this task as Resolved.Aug 31 2021, 6:14 PM
Jdforrester-WMF moved this task from To Triage to To triage: Un-phased work on the Abstract Wikipedia team board.

The AutocompleteSearchInput component we're using takes the labels as plain text, so we can't style the label and alias differently. Let's declare this done for now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits