Page MenuHomePhabricator
Create Task
Maniphest T289805

Constraint checks do not support Unicode characters properly
Closed, ResolvedPublic
Actions

Description

There are constraint violations being shown which are not actually violations, caused by Unicode characters not being matched correctly. This applies to both Special:ConstraintReport and the icons shown on entity pages.

Examples:

Details

SubjectRepoBranchLines +/-
Fix regex checking using preg_match()mediawiki/extensions/WikibaseQualityConstraintsmaster+4 -2
Customize query in gerrit

Event Timeline

Nikki created this task.Aug 26 2021, 6:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2021, 6:43 PM
Maintenance_bot added a project: Wikidata.Aug 26 2021, 6:45 PM
Lucas_Werkmeister_WMDE claimed this task.Aug 27 2021, 7:53 AM
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Lucas_Werkmeister_WMDE subscribed.

Picking this up directly as a small tech fix.

gerritbot added a comment.Aug 27 2021, 7:54 AM

Change 715201 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Fix regex checking using preg_match()

https://gerrit.wikimedia.org/r/715201

gerritbot added a project: Patch-For-Review.Aug 27 2021, 7:54 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2021, 7:54 AM
gerritbot added a comment.Aug 27 2021, 9:35 AM

Change 715201 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Fix regex checking using preg_match()

https://gerrit.wikimedia.org/r/715201

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2021, 9:50 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 27 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 27 2021, 10:10 AM
Addshore closed this task as Resolved.Aug 31 2021, 5:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits