Page MenuHomePhabricator
Create Task
Maniphest T289825

NPP Feed broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):
Go to Special:NewPagesFeed on enwiki

What happens?:
Different editors are reporting different issues. It may load nothing or it may load a small number of pages. Some sort of loading message is also reported.

What should have happened instead?:

The complete New Page feed loads.

Software version (if not a Wikimedia wiki), browser information, screenshots, other , etc:
See also: https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Feed_broken?

24x3riSd.png (261×500 px, 46 KB)

Screenshot 2021-08-26 5.13.29 PM.png (1×1 px, 408 KB)

Details

SubjectRepoBranchLines +/-
Revert "Update backbone.js and underscore.js"mediawiki/extensions/PageTriagemaster+2 K -4 K
Revert "Update backbone.js and underscore.js"mediawiki/extensions/PageTriagewmf/1.37.0-wmf.20+2 K -4 K
Customize query in gerrit

Related Objects

Event Timeline

Barkeep49 created this task.Aug 27 2021, 12:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2021, 12:14 AM
Legoktm added a project: PageTriage.Aug 27 2021, 12:17 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 27 2021, 12:17 AM
Legoktm added a subscriber: Legoktm.EditedAug 27 2021, 12:20 AM

When I load https://en.wikipedia.org/wiki/Special:NewPagesFeed it gets stuck until Firefox prompts me to stop the page.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/666595 is probably the cause, unfortunately. Testing if a revert of that fixes this...

Legoktm added subscribers: Ladsgroup, Krinkle.Aug 27 2021, 12:23 AM
Legoktm added a subscriber: kostajh.
gerritbot added a comment.Aug 27 2021, 12:25 AM

Change 715148 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/PageTriage@master] Revert \"Update backbone.js and underscore.js\"

https://gerrit.wikimedia.org/r/715148

gerritbot added a project: Patch-For-Review.Aug 27 2021, 12:25 AM

Change 715087 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/PageTriage@wmf/1.37.0-wmf.20] Revert \"Update backbone.js and underscore.js\"

https://gerrit.wikimedia.org/r/715087

Legoktm added a comment.Aug 27 2021, 12:40 AM

CI is broken, however @Barkeep49 verified that with the revert and bypassing cache NewPagesFeed works again, so I'm going to force merge and sync it out.

gerritbot added a comment.Aug 27 2021, 12:40 AM

Change 715087 merged by Legoktm:

[mediawiki/extensions/PageTriage@wmf/1.37.0-wmf.20] Revert \"Update backbone.js and underscore.js\"

https://gerrit.wikimedia.org/r/715087

Stashbot added a comment.Aug 27 2021, 12:44 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-27T00:44:14Z] <legoktm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/PageTriage/: Revert backbone.js and underscore.js updates (T289825) (duration: 01m 06s)

gerritbot added a comment.Aug 27 2021, 12:50 AM

Change 715148 merged by Legoktm:

[mediawiki/extensions/PageTriage@master] Revert \"Update backbone.js and underscore.js\"

https://gerrit.wikimedia.org/r/715148

Legoktm closed this task as Resolved.Aug 27 2021, 12:50 AM
Legoktm claimed this task.
Legoktm triaged this task as Unbreak Now! priority.

Should be fixed now. I filed T289830: PageTriage tests failing in Jenkins for the CI failure.

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2021, 1:10 AM
Ladsgroup added a comment.Aug 27 2021, 9:46 AM

:(( I tested it in beta cluster...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL