Page MenuHomePhabricator
Create Task
Maniphest T289859

Wikimedia\Rdbms\Database::assertValidUpsertSetArray called with redundant assignment to column 'gelr_revision'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
Wikimedia\Rdbms\Database::assertValidUpsertSetArray called with redundant assignment to column 'gelr_revision'
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.20/includes/libs/rdbms/database/Database.php(2366)
#0 /srv/mediawiki/php-1.37.0-wmf.20/includes/libs/rdbms/database/Database.php(3566): Wikimedia\Rdbms\Database->assertValidUpsertSetArray(array, array, array)
#1 /srv/mediawiki/php-1.37.0-wmf.20/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->upsert(string, array, string, array, string)
#2 /srv/mediawiki/php-1.37.0-wmf.20/includes/libs/rdbms/database/DBConnRef.php(512): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#3 /srv/mediawiki/php-1.37.0-wmf.20/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/LinkRecommendationStore.php(218): Wikimedia\Rdbms\DBConnRef->upsert(string, array, string, array, string)
#4 /srv/mediawiki/php-1.37.0-wmf.20/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/LinkRecommendationUpdater.php(142): GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendationStore->insert(GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendation)
#5 /srv/mediawiki/php-1.37.0-wmf.20/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(281): GrowthExperiments\NewcomerTasks\AddLink\LinkRecommendationUpdater->processCandidate(Title, boolean)
#6 /srv/mediawiki/php-1.37.0-wmf.20/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(162): GrowthExperiments\Maintenance\RefreshLinkRecommendations->processCandidate(Title, boolean)
#7 /srv/mediawiki/php-1.37.0-wmf.20/maintenance/doMaintenance.php(108): GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.20/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(309): require_once(string)
#9 /srv/mediawiki/multiversion/MWScript.php(116): require_once(string)
#10 {main}
Impact

A link recommendation is not saved to the database when this error occurs.

Notes

This occurs in the refreshLinkRecommendations maintenance script, so not user facing and could wait until Monday for a backport.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix Database::upsert with ::replace in LinkRecommendationStoremediawiki/extensions/GrowthExperimentsmaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Aug 27 2021, 1:35 PM
kostajh triaged this task as High priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2021, 1:35 PM
Aklapper added projects: GrowthExperiments-NewcomerTasks, Add-Link-Structured-Task.Aug 27 2021, 4:01 PM
gerritbot added a comment.Aug 31 2021, 7:52 PM

Change 715783 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Fix Database::upsert in LinkRecommendationStore

https://gerrit.wikimedia.org/r/715783

gerritbot added a project: Patch-For-Review.Aug 31 2021, 7:52 PM
Tgr subscribed.Sep 1 2021, 1:03 AM

Apparently the warning was added last week in rMWacd3a5379959: rdbms: add unique key checks to upsert() and replace() in Database. (There is also an exception, but this was the warning branch, so no impact beyond logspam.)

Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Sep 1 2021, 2:53 AM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.EditedSep 1 2021, 2:47 PM

Was rMWacd3a5379959: rdbms: add unique key checks to upsert() and replace() in Database reverted? I don't see why there would be such a sharp drop off (but also, these messages haven't been eliminated)

image.png (786×1 px, 154 KB)

Etonkovidova subscribed.EditedSep 3 2021, 12:52 AM

For the last 24 hours (the latest timestamp Sep 2, 2021 @ 23:48:42.345) there were 134 warnings recorded in the logstash.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 3 2021, 11:29 AM
gerritbot added a comment.Sep 3 2021, 11:44 AM

Change 715783 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix Database::upsert with ::replace in LinkRecommendationStore

https://gerrit.wikimedia.org/r/715783

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 3 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2021, 12:10 PM
kostajh moved this task from Backlog to Done / QA on the Add-Link-Structured-Task board.Sep 3 2021, 12:20 PM
Umherirrender closed this task as Resolved.Sep 3 2021, 11:58 PM
Umherirrender claimed this task.
Tgr merged a task: T290632: Wikimedia\Rdbms\Database::assertValidUpsertSetArray called with redundant assignment to column 'gelr_revision'.Sep 9 2021, 5:49 AM
Tgr added subscribers: Marostegui, Umherirrender.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits