Page MenuHomePhabricator
Create Task
Maniphest T289864

Error: Call to a member function getPath() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getPath() on null
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.20/extensions/Score/includes/Score.php(550)
#0 /srv/mediawiki/php-1.37.0-wmf.20/extensions/Score/includes/Score.php(404): Score::generateHTML(Parser, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.20/extensions/Score/includes/Score.php(264): Score::renderScore(string, array, Parser)
#2 /srv/mediawiki/php-1.37.0-wmf.20/includes/parser/Parser.php(3975): Score::render(string, array, Parser, PPFrame_Hash)
#3 /srv/mediawiki/php-1.37.0-wmf.20/includes/parser/PPFrame_Hash.php(351): Parser->extensionSubstitution(array, PPFrame_Hash)
#4 /srv/mediawiki/php-1.37.0-wmf.20/includes/parser/Parser.php(2932): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#5 /srv/mediawiki/php-1.37.0-wmf.20/includes/parser/Parser.php(1600): Parser->replaceVariables(string)
#6 /srv/mediawiki/php-1.37.0-wmf.20/includes/parser/Parser.php(655): Parser->internalParse(string)
#7 /srv/mediawiki/php-1.37.0-wmf.20/includes/content/WikitextContent.php(327): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#8 /srv/mediawiki/php-1.37.0-wmf.20/includes/content/AbstractContent.php(545): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#9 /srv/mediawiki/php-1.37.0-wmf.20/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#10 /srv/mediawiki/php-1.37.0-wmf.20/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#11 /srv/mediawiki/php-1.37.0-wmf.20/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#12 /srv/mediawiki/php-1.37.0-wmf.20/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#13 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#14 /srv/mediawiki/php-1.37.0-wmf.20/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#15 /srv/mediawiki/php-1.37.0-wmf.20/includes/content/ContentHandler.php(1435): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#16 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(85): ContentHandler->getParserOutputForIndexing(WikiPage, ParserCache)
#17 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(68): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, ParserCache, CirrusSearch\CirrusSearch)
#18 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(165): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, Title)
#19 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/DataSender.php(316): CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document)
#20 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/Job/ElasticaWrite.php(136): CirrusSearch\DataSender->sendData(string, array)
#21 /srv/mediawiki/php-1.37.0-wmf.20/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\ElasticaWrite->doJob()
#22 /srv/mediawiki/php-1.37.0-wmf.20/extensions/EventBus/includes/JobExecutor.php(79): CirrusSearch\Job\CirrusGenericJob->run()
#23 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#24 {main}
Notes

Very low frequency.

Details

Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Check backend local ref for MIDI file, bail cleanly if not foundJonathanischoicemediawiki/extensions/Scoremaster+3 -0
Customize query in gerrit

Event Timeline

dancy created this task.Aug 27 2021, 2:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2021, 2:45 PM
dancy updated the task description. (Show Details)Aug 27 2021, 2:46 PM
Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Sep 1 2021, 2:52 AM
Krinkle added subscribers: Legoktm, Krinkle.

\cc @Legoktm who's been refactoring this area recently. This issue is from the from current/last week wmf.20 branch, which didn't have any of those refactors in it yet afaics, but \cc-ing nonetheless :)

Legoktm added a comment.Sep 1 2021, 7:32 AM

Code snippet:

					// Maybe we just generated it
					$sourcePath = "{$options['factory_directory']}/file.midi";
					if ( !file_exists( $sourcePath ) ) {
						// No, need to fetch it from the backend
						$sourceFileRef = $backend->getLocalReference(
							[ 'src' => "{$options['dest_storage_path']}/$midiFileName" ] );
						$sourcePath = $sourceFileRef->getPath();
					}

So either:

  • logic mismatch, we are not generating the MIDI file in generatePngAndMidi() even though we need it later on
  • we thought it existed in swift so we didn't generate it, but when trying to fetch it it actually doesn't exist

Elsewhere there's a block like:

		$needMidi = false;
		$haveMidi = $result->wasReceived( 'file.midi' );
		if ( !$options['raw'] || $options['generate_audio'] && !$options['override_midi'] ) {
			$needMidi = true;
			if ( !$haveMidi ) {
				throw new ScoreException( wfMessage( 'score-nomidi' ) );
			}
		}

Maybe the $needMidi logic should be consolidated in one place.

Krinkle added a project: Unowned-production-error.Mar 15 2022, 12:26 AM
Krinkle moved this task from Aug 2021 to Older on the Wikimedia-production-error board.Feb 22 2024, 4:41 PM
Krinkle edited projects, added: Editing-team; removed: Unowned-production-error.Apr 3 2025, 8:54 AM

Still seen. Tagging Editing-team for the Score extension, per mw:Maintainers.

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getPath() on bool
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/extensions/Score/includes/Score.php(578)
#0/srv/mediawiki/php-1.44.0-wmf.18/extensions/Score/includes/Score.php(424)MediaWiki\Extension\Score\Score::generateHTML(MediaWiki\Parser\Parser, string, array)
#1/srv/mediawiki/php-1.44.0-wmf.18/extensions/Score/includes/Score.php(280)MediaWiki\Extension\Score\Score::renderScore(string, array, MediaWiki\Parser\Parser)
………
#28/srv/mediawiki/php-1.44.0-wmf.18/includes/content/Renderer/ContentRenderer.php(75)MediaWiki\Content\ContentHandler->getParserOutput(ProofreadPage\Page\PageContent, MediaWiki\Content\Renderer\ContentParseParams)
#29/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiParse.php(158)MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(ProofreadPage\Page\PageContent, MediaWiki\Title\Title, null, MediaWiki\Parser\ParserOptions)
………
#33/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiParse.php(442)MediaWiki\Api\ApiParse->getContentParserOutput(ProofreadPage\Page\PageContent, MediaWiki\Title\Title, null, MediaWiki\Parser\ParserOptions)
#34/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(2012)MediaWiki\Api\ApiParse->execute()
………
DLynch subscribed.Apr 3 2025, 3:04 PM

This seems to have happened precisely once in the last year.

The error happened here:

$sourcePath = "{$options['factory_directory']}/file.midi";
if ( !file_exists( $sourcePath ) ) {
	// No, need to fetch it from the backend
	$sourceFileRef = $backend->getLocalReference(
		[ 'src' => "{$options['dest_storage_path']}/$midiFileName" ] );
	$sourcePath = $sourceFileRef->getPath();
}

So a quick fix would be to check whether that getLocalReference call actually succeeded, I guess?

gerritbot added a comment.Jul 22 2026, 11:30 AM

Change #1313914 had a related patch set uploaded (by Jonathanischoice; author: Jonathanischoice):

[mediawiki/extensions/Score@master] Check backend local ref for MIDI file, bail cleanly if not found

https://gerrit.wikimedia.org/r/1313914

gerritbot added a project: Patch-For-Review.Jul 22 2026, 11:30 AM
Jonathanischoice moved this task from Backlog to In Progress on the MediaWiki-extensions-Score board.Jul 22 2026, 11:32 AM
Jonathanischoice added a subscriber: Amire80.
Jonathanischoice claimed this task.Jul 24 2026, 12:47 PM
Jonathanischoice changed the task status from Open to In Progress.Jul 24 2026, 3:29 PM
TheDJ added a project: Wikimania-Hackathon-2026.Jul 25 2026, 9:22 AM
gerritbot added a comment.Aug 8 2026, 10:31 AM

Change #1313914 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Check backend local ref for MIDI file, bail cleanly if not found

https://gerrit.wikimedia.org/r/1313914

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.15; 2026-08-11).Aug 8 2026, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 8 2026, 11:30 AM
Jonathanischoice closed this task as Resolved.Mon, Sep 14, 2:08 AM

I assume since it's now merged, this can be closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits