Page MenuHomePhabricator
Create Task
Maniphest T289913

CentralAuthUser should only deal with users
Open, Needs TriagePublic
Actions

Description

CentralAuthUser currently also contains a bunch of helper functions such as those dealing with global groups, listing all CA wikis or connecting to the CA database. Those should be moved to better places.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move ::centralLBHasRecentPrimaryChanges() to CentralAuthDatabaseManagermediawiki/extensions/CentralAuthmaster+14 -17
CAUser: Drop unused getWikiList()mediawiki/extensions/CentralAuthmaster+0 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT289913 CentralAuthUser should only deal with users
 OpenNoneT270857 Introduce a service for global group storage

Event Timeline

taavi created this task.Aug 28 2021, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2021, 1:00 PM
taavi moved this task from Unsorted to Separate concerns on the Technical-Debt board.Aug 28 2021, 1:00 PM
taavi added a subtask: T270857: Introduce a service for global group storage.
gerritbot added a comment.Sep 4 2021, 7:43 AM

Change 718185 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] CAUser: Drop unused getWikiList()

https://gerrit.wikimedia.org/r/718185

gerritbot added a project: Patch-For-Review.Sep 4 2021, 7:43 AM
gerritbot added a comment.Sep 4 2021, 8:00 PM

Change 718185 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CAUser: Drop unused getWikiList()

https://gerrit.wikimedia.org/r/718185

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2021, 8:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 4 2021, 9:00 PM
gerritbot added a comment.Dec 7 2021, 3:34 PM

Change 744103 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Move ::centralLBHasRecentPrimaryChanges() to CentralAuthDatabaseManager

https://gerrit.wikimedia.org/r/744103

gerritbot added a project: Patch-For-Review.Dec 7 2021, 3:34 PM
gerritbot added a comment.Dec 7 2021, 3:54 PM

Change 744103 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Move ::centralLBHasRecentPrimaryChanges() to CentralAuthDatabaseManager

https://gerrit.wikimedia.org/r/744103

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 7 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits