Page MenuHomePhabricator

SecurePoll should use the new hook runner system for its own hooks
Closed, ResolvedPublic

Description

T275617: Update SecurePoll to use the new HookContainer/HookRunner system updated SecurePoll to use the new hook system for its hook handlers. SecurePoll also emits its own hooks, SecurePoll_GetUserParams and SecurePoll_JumpUrl, and those should be converted to the new system as well, namely adding hook interfaces that other extensions can use and a hook runner class. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/664895 for an example in CentralAuth.

Event Timeline

Change 716078 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@master] Use the new hook system for hooks provided by SecurePoll

https://gerrit.wikimedia.org/r/716078

Change 716078 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Use the new hook system for hooks provided by SecurePoll

https://gerrit.wikimedia.org/r/716078

Change 730215 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurePoll@master] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730215

Change 730230 had a related patch set uploaded (by Majavah; author: Zabe):

[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.3] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730230

Change 730231 had a related patch set uploaded (by Majavah; author: Zabe):

[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.4] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730231

Change 730215 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730215

Change 730230 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.3] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730230

Mentioned in SAL (#wikimedia-operations) [2021-10-12T15:58:15Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/SecurePoll/includes/Hooks/HookRunner.php: Backport: [[gerrit:730230|Fix wrong var being passed (T289950 T293102)]] (duration: 02m 13s)

Change 730231 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.38.0-wmf.4] Fix wrong var being passed

https://gerrit.wikimedia.org/r/730231

Mentioned in SAL (#wikimedia-operations) [2021-10-12T16:06:08Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/SecurePoll/includes/Hooks/HookRunner.php: Backport: [[gerrit:730231|Fix wrong var being passed (T289950 T293102)]] (duration: 00m 57s)

Majavah assigned this task to Zabe.