action=watch does not show success message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Aug 30 2021, 12:00 AM

Description

Steps to reproduce

Log in to meta.wikimedia
Go to https://meta.wikimedia.org/w/index.php?title=Meta:Requests_for_adminship/Cabayi&action=watch
Click "Submit"

Expected behavior

Page is added to my watchlist and a success message is shown.

Observed behavior

An empty error screen is returned, but page is added to my watchlist.

Notes

I use Timeless as my skin.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_37	+8 -6	Wrap StatusValue in Status for HTMLForm submit callback
	mediawiki/core	master	+6 -6	Wrap StatusValue in Status for HTMLForm submit callback

Customize query in gerrit

Related Objects

Duplicates Merged Here: T298780: Watch action consistently broken with useless "Error: ok" message

Event Timeline

Urbanecm created this task.Aug 30 2021, 12:00 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2021, 12:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Also able to reproduce in Vector as well. Moving to Needs Discussion to prioritize

1234qwer1234qwer4 added a subscriber: 1234qwer1234qwer4.Sep 22 2021, 9:58 PM

Sakura_emad added a subscriber: Sakura_emad.Sep 23 2021, 12:39 AM

Urbanecm merged a task: T298780: Watch action consistently broken with useless "Error: ok" message .Jan 7 2022, 4:08 PM

Urbanecm added a subscriber: Krinkle.

Ammarpad claimed this task.Jan 7 2022, 4:45 PM

Change 752175 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Wrap StatusValue in Status for HTMLForm submit callback

https://gerrit.wikimedia.org/r/752175

gerritbot added a project: Patch-For-Review.Jan 7 2022, 5:14 PM

Change 752175 merged by jenkins-bot:

[mediawiki/core@master] Wrap StatusValue in Status for HTMLForm submit callback

https://gerrit.wikimedia.org/r/752175

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 8 2022, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2022, 11:10 AM

Change 752266 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@REL1_37] Wrap StatusValue in Status for HTMLForm submit callback

https://gerrit.wikimedia.org/r/752266

gerritbot added a project: Patch-For-Review.Jan 8 2022, 11:32 AM

Change 752266 merged by jenkins-bot: