Page MenuHomePhabricator

Refactor the observer.vue component
Closed, ResolvedPublic

Description

The Observer component is used in many components (App, searchfilters, Image, Tabs) and in each of this it includes some functionality that could be refactored to actually be included in the actual component.

This refactoring is the beginning proposal for a refactoring of the app.vue file

QA Notes

Check to ensure the following functionality has not changed/regressed in any way (this patch should not cause any user-facing changes):

  • Autoloading results as the user scrolls down the page
  • Showing/hiding the gradient in the filters bar (and general horizontal scrolling behavior here) when the display is too small to fit all options in the viewport.

Event Timeline

Due to lack of FE ticket I am picking this up before Estimation to have something to work on!

I estimate it to be a medium due to the reach and test required on different components.

Change 719256 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the observer.vue component

https://gerrit.wikimedia.org/r/719256

Change 719256 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the observer.vue component

https://gerrit.wikimedia.org/r/719256

Change 720711 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Update Observer comments

https://gerrit.wikimedia.org/r/720711

Change 720711 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Update Observer comments

https://gerrit.wikimedia.org/r/720711

Etonkovidova subscribed.

Checked in commons wmf.2 - works as expected.

Thanks, @SimoneThisDot for QA notes in the task description!