Page MenuHomePhabricator
Create Task
Maniphest T290006

Notifications for multiple replies don't scroll to the topmost comment sometimes
Closed, ResolvedPublic
Actions

Description

Notifications for multiple replies don't scroll to the topmost comment sometimes.

The following link (copied from a notification I got this morning) scrolls to the second comment for some reason (even though the highlighting works as expected):

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&dtnewcomments=c-Xaosflux-2021-08-30T13%3A29%3A00.000Z-Chipmunkdavis-2021-08-30T12%3A39%3A00.000Z%7Cc-Qwerfjkl-2021-08-30T12%3A52%3A00.000Z-Chipmunkdavis-2021-08-30T12%3A47%3A00.000Z%7Cc-Qwerfjkl-2021-08-30T12%3A48%3A00.000Z-RoySmith-2021-08-28T14%3A33%3A00.000Z%7Cc-Chipmunkdavis-2021-08-30T12%3A47%3A00.000Z-Qwerfjkl-2021-08-30T12%3A45%3A00.000Z%7Cc-Qwerfjkl-2021-08-30T12%3A45%3A00.000Z-Chipmunkdavis-2021-08-30T12%3A39%3A00.000Z%7Cc-Chipmunkdavis-2021-08-30T12%3A39%3A00.000Z-So_what_happens_if_some_dummy_edits_the_heading%3F%7Cc-RoySmith-2021-08-30T12%3A35%3A00.000Z-Matma_Rex-2021-08-30T12%3A05%3A00.000Z#So_what_happens_if_some_dummy_edits_the_heading%3F

Actual
image.png (2×3 px, 930 KB)
Expected
image.png (2×3 px, 933 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix finding topmost comment when there are 3+ highlightedmediawiki/extensions/DiscussionToolsmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Aug 30 2021, 1:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2021, 1:52 PM
gerritbot added a comment.Aug 30 2021, 2:00 PM

Change 715504 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix finding topmost comment when there are 3+ highlighted

https://gerrit.wikimedia.org/r/715504

gerritbot added a project: Patch-For-Review.Aug 30 2021, 2:00 PM
matmarex claimed this task.Aug 30 2021, 2:00 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
matmarex mentioned this in T286620: Bundled notifications get processed singly.
ppelberg subscribed.Aug 30 2021, 3:39 PM
gerritbot added a comment.Aug 30 2021, 4:03 PM

Change 715504 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix finding topmost comment when there are 3+ highlighted

https://gerrit.wikimedia.org/r/715504

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2021, 4:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 30 2021, 4:37 PM
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 30 2021, 5:00 PM
• LZaman moved this task from Inbox to High Priority on the Editing QA board.Aug 30 2021, 5:12 PM
• LZaman moved this task from High Priority to Inbox on the Editing QA board.Aug 30 2021, 5:21 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Aug 30 2021, 11:48 PM
ppelberg moved this task from Inbox to High Priority on the Editing QA board.Sep 2 2021, 7:18 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 2 2021, 8:34 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 2 2021, 8:38 PM
ppelberg closed this task as Resolved.Sep 4 2021, 12:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits